Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Is OB affected by the BIP39 bug? #384

Closed
JustinDrake opened this issue Feb 23, 2017 · 4 comments
Closed

Is OB affected by the BIP39 bug? #384

JustinDrake opened this issue Feb 23, 2017 · 4 comments
Assignees
Labels

Comments

@JustinDrake
Copy link
Contributor

OpenBazaar makes use of BIP39. See discussion iancoleman/bip39#58

@bip32JP
Copy link

bip32JP commented Feb 23, 2017

BIP32 bug actually

Specifically in hardened key derivation where private keys are not properly padded when the MSB is a 0x00 byte.

This means there is a 1/256 chance that this bug occurs on any BIP32 wallet that contains hardened derivation.

@hoffmabc
Copy link
Member

From that thread it seems as though wallets built off of bitcore are affected due to the dropping of the byte. We're building off of btcd so I'm not sure of this affecting us. @cpacia ?

@hoffmabc
Copy link
Member

So the answer is no problem?

@cpacia
Copy link
Member

cpacia commented Feb 23, 2017

I think btcd handles the padding correctly. I get 17rxURoF96VhmkcEGCj5LNQkmN9HVhWb7F from that test vector which is consistent with the others.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants