Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do HeaderDB really need a lock? #53

Open
zouxyan opened this issue Sep 4, 2019 · 0 comments
Open

Do HeaderDB really need a lock? #53

zouxyan opened this issue Sep 4, 2019 · 0 comments

Comments

@zouxyan
Copy link

zouxyan commented Sep 4, 2019

BoltDB should already guarantee the transactionality of reading and writing the database. So, is the lock of HeaderDB necessary ?

type HeaderDB struct {
	lock      *sync.Mutex // really need it ? 
	db        *bolt.DB
	filePath  string
	bestCache *StoredHeader
	cache     *HeaderCache
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant