Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TurbineType logic is incorrect after TCF merge #667

Open
bjonkman opened this issue Feb 24, 2021 · 0 comments
Open

TurbineType logic is incorrect after TCF merge #667

bjonkman opened this issue Feb 24, 2021 · 0 comments

Comments

@bjonkman
Copy link
Contributor

Bug description
The logic in the OpenFAST glue code (variable p%TurbineType in subroutine FAST_Init) was not updated with #537, so it still assumes that using HydroDyn + SubDyn means a fixed-bottom offshore turbine. This gets printed in the OpenFAST summary file. @jjonkman recommends removing that logic completely, though turbine type is used in a couple of checks elsewhere in the code, too. Based on other modeling needs (my own!), I suggest that we just differentiate between offshore and onshore turbines for now instead of the further differentiation between fixed and floating offshore.

This is pretty low priority, so I'm documenting the issue here instead of fixing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant