Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The line break character in the name of the conversation file causes the OSError error #1404

Open
Dixter-TES opened this issue Aug 15, 2024 · 2 comments · Fixed by #1448
Open
Labels
Good First issue Good for newcomers

Comments

@Dixter-TES
Copy link

Describe the bug

During the neural network response, a situation may occur in which the first few words used to generate the file name contain the \n character, which is not removed during the check in the interpreter\core\core.py file (284 line) and an OSError will be generated.

The easiest solution I see is to add the character \n to the list of characters on line 272.

Now: '<>:"/\|?!'
Will be: '<>:"/\|?
!\n'

Reproduce

You just need to compose a query where the neural network uses a line break in the first few characters.

Expected behavior

Successful creation of the file was expected.

Screenshots

image

Open Interpreter version

0.3.7

Python version

3.10.11

Operating System name and version

Windows 11

Additional context

No response

@QUAGZA
Copy link
Contributor

QUAGZA commented Sep 10, 2024

hey i have added '\n' as part of the invalid characters for filenames, if it all checks out could you approve my PR

@QUAGZA
Copy link
Contributor

QUAGZA commented Oct 29, 2024

can someone close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants