-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1127 mac UI test integration #1156
#1127 mac UI test integration #1156
Conversation
…changes for windows and linux
Changes looks good to me. Just waiting for the build results in this PR and some runs that running in fork actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's wait for the build to complete successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the recent UI changes, since the terminal tab is now labeled "Terminal" instead of "Terminal:". Consequently, the rightClickOnTerminalTab
method in ProjectFrameFixture.java
needs to be updated to reflect this change.
In the current builds with these changes, the UIBotTestUtils.closeTerminalTabs is not getting executed correctly.
Fixed this issue in the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also only had one comment, but think you can move forward without changing that code right now. Please check that the Mac build is passing. The build results weren't available yet when I did this review.
Build results: That got successful in fork repo for MAC: 2024.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good , Thanks @staicy123 for your valuable effort to update Mac UI changes.
c808816
into
OpenLiberty:intellij-2024.2-support-backup
Fixes #1066 and #1127
UI Code Modifications for Mac:
Issue Resolutions During Integration: