Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1127 mac UI test integration #1156

Conversation

staicy123
Copy link
Contributor

@staicy123 staicy123 commented Dec 5, 2024

Fixes #1066 and #1127
UI Code Modifications for Mac:

  • Updated the UI code to support IntelliJ versions 2024.3 and 2024.2.
  • Introduced conditional logic to handle UI differences between these versions, ensuring compatibility with both.
  • Added conditional checks to handle differences in the UI between Mac and Windows/Linux platforms.
    Issue Resolutions During Integration:
  • NullPointerException in detectFatalError Method:
    • While integrating changes from the main and intellij-2024.2-support-backup branches into the updated UI code, encountered a NullPointerException when running individual UI tests locally.
    • Root Cause: The detectFatalError method relies on the presence of the junit.out file in the build folder, which is generated during CI/CD pipeline execution via the ./gradlew test command (configured using export JUNIT_OUTPUT_TXT).
    • Resolution: Added a null check to handle cases where this file is not generated during local test execution.
  • Heap OutOfMemoryError in GHA:
    • Encountered a Heap OutOfMemoryError while integrating the latest JDK changes in GitHub Actions (GHA) builds.
    • Resolution: Increased memory allocation to address the issue, ensuring successful builds in GHA.

@staicy123 staicy123 marked this pull request as ready for review December 5, 2024 11:25
@vaisakhkannan
Copy link
Contributor

Changes looks good to me. Just waiting for the build results in this PR and some runs that running in fork actions

Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait for the build to complete successfully.

Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the recent UI changes, since the terminal tab is now labeled "Terminal" instead of "Terminal:". Consequently, the rightClickOnTerminalTab method in ProjectFrameFixture.java needs to be updated to reflect this change.
In the current builds with these changes, the UIBotTestUtils.closeTerminalTabs is not getting executed correctly.

@staicy123
Copy link
Contributor Author

With the recent UI changes, since the terminal tab is now labeled "Terminal" instead of "Terminal:". Consequently, the rightClickOnTerminalTab method in ProjectFrameFixture.java needs to be updated to reflect this change. In the current builds with these changes, the UIBotTestUtils.closeTerminalTabs is not getting executed correctly.

Fixed this issue in the PR
Thanks

turkeylurkey
turkeylurkey previously approved these changes Dec 5, 2024
Copy link
Member

@turkeylurkey turkeylurkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion.

mrglavas
mrglavas previously approved these changes Dec 5, 2024
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also only had one comment, but think you can move forward without changing that code right now. Please check that the Mac build is passing. The build results weren't available yet when I did this review.

@staicy123
Copy link
Contributor Author

staicy123 commented Dec 6, 2024

I also only had one comment, but think you can move forward without changing that code right now. Please check that the Mac build is passing. The build results weren't available yet when I did this review.

Build results: That got successful in fork repo for MAC:
2024.2.5
https://github.com/staicy123/liberty-tools-intellij/actions/runs/12178426548

2024.3
https://github.com/staicy123/liberty-tools-intellij/actions/runs/12178393099
https://github.com/staicy123/liberty-tools-intellij/actions/runs/12181098034
https://github.com/staicy123/liberty-tools-intellij/actions/runs/12182495382

Build got successful in liberty repo
 for Mac:
https://github.com/OpenLiberty/liberty-tools-intellij/actions/runs/12182496764
https://github.com/OpenLiberty/liberty-tools-intellij/actions/runs/12181098570

TrevCraw
TrevCraw previously approved these changes Dec 6, 2024
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good , Thanks @staicy123 for your valuable effort to update Mac UI changes.

@dessina-devasia dessina-devasia merged commit c808816 into OpenLiberty:intellij-2024.2-support-backup Dec 6, 2024
3 checks passed
@vaisakhkannan
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants