Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bearerTokenSecret not propagated to Service Monitor #157

Closed
awisniew90 opened this issue May 13, 2020 · 1 comment
Closed

bearerTokenSecret not propagated to Service Monitor #157

awisniew90 opened this issue May 13, 2020 · 1 comment
Assignees
Labels

Comments

@awisniew90
Copy link

Bug Report

What did you do?

Configuring bearerTokenSecret on the deployment's monitoring endpoint does not propagate to the created Service Monitor.

app-deploy.yaml:

monitoring:
    endpoints:
    - bearerTokenSecret:
        key: token
        name: my-test-token-token-v2ktw
      interval: 5s
      tlsConfig:
        insecureSkipVerify: true
    labels:
      app-monitoring: ""

Resulting Service Monitor:

spec:
  endpoints:
    - bearerTokenSecret:
        key: ''
      interval: 5s
      port: 9080-tcp
      tlsConfig:
        ca: {}
        cert: {}
        insecureSkipVerify: true

What did you expect to see?

The generated service monitor should contain the bearerTokenSecret defined in the deployment.

What did you see instead?

The bearerTokenSecret configuration is not propagated to the service monitor due to the property missing from servicemonitor.crd.yaml

Environment

  • Kubernetes version information:

1.16.2

  • OpenShift version information (if applicable):

Client Version: 4.3.5
Server Version: 4.3.0
Kubernetes Version: v1.16.2

  • Appsody CLI version (if applicable):

0.6.1

  • Appsody Stack (if applicable):

java-openliberty

Possible solution

Adding the bearerTokenSecret config to servicemonitor.crd.yaml

@arturdzm
Copy link
Contributor

Fixed in 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants