Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Test Summary for Jakarta Pages 3.1 #21284

Closed
pnicolucci opened this issue Jun 1, 2022 · 2 comments
Closed

Feature Test Summary for Jakarta Pages 3.1 #21284

pnicolucci opened this issue Jun 1, 2022 · 2 comments

Comments

@pnicolucci
Copy link
Member

Test Strategy

Describe the test strategy & approach for this feature, and describe how the approach verifies the functions delivered by this feature.

For any feature, be aware that only FAT tests (not unit or BVT) are executed in our cross platform testing. To ensure cross platform testing ensure you have sufficient FAT coverage to verify the feature.

If delivering tests outside of the standard Liberty FAT framework, do the tests push the results into cognitive testing database (if not, consult with the CSI Team who can provide advice and verify if results are being received)?

List of FAT projects affected

Test strategy

  • What functionality is new or modified by this feature?
  • What are the positive and negative tests for that functionality? (Tell me the specific scenarios you tested. What kind of tests do you have for when everything ends up working (positive tests)? What about tests that verify we fail gracefully when things go wrong (negative tests)? See the Positive and negative tests section of the Feature Test Summary Process wiki for more detail.)
  • What manual tests are there (if any)? (Note: Automated testing is expected for all features with manual testing considered an exception to the rule.)

Confidence Level

Collectively as a team you need to assess your confidence in the testing delivered based on the values below. This should be done as a team and not an individual to ensure more eyes are on it and that pressures to deliver quickly are absorbed by the team as a whole.

Please indicate your confidence in the testing (up to and including FAT) delivered with this feature by selecting one of these values:

0 - No automated testing delivered

1 - We have minimal automated coverage of the feature including golden paths. There is a relatively high risk that defects or issues could be found in this feature.

2 - We have delivered a reasonable automated coverage of the golden paths of this feature but are aware of gaps and extra testing that could be done here. Error/outlying scenarios are not really covered. There are likely risks that issues may exist in the golden paths

3 - We have delivered all automated testing we believe is needed for the golden paths of this feature and minimal coverage of the error/outlying scenarios. There is a risk when the feature is used outside the golden paths however we are confident on the golden path. Note: This may still be a valid end state for a feature... things like Beta features may well suffice at this level.

4 - We have delivered all automated testing we believe is needed for the golden paths of this feature and have good coverage of the error/outlying scenarios. While more testing of the error/outlying scenarios could be added we believe there is minimal risk here and the cost of providing these is considered higher than the benefit they would provide.

5 - We have delivered all automated testing we believe is needed for this feature. The testing covers all golden path cases as well as all the error/outlying scenarios that make sense. We are not aware of any gaps in the testing at this time. No manual testing is required to verify this feature.

Based on your answer above, for any answer other than a 4 or 5 please provide details of what drove your answer. Please be aware, it may be perfectly reasonable in some scenarios to deliver with any value above. We may accept no automated testing is needed for some features, we may be happy with low levels of testing on samples for instance so please don't feel the need to drive to a 5. We need your honest assessment as a team and the reasoning for why you believe shipping at that level is valid. What are the gaps, what is the risk etc. Please also provide links to the follow on work that is needed to close the gaps (should you deem it needed)

@isaacrivriv
Copy link
Member

Jakarta Pages 3.1: #18737

Repeated tests: The bucket com.ibm.ws.jsp.2.3 has been enabled for repeat on EE10. An additional bucket in WS-CD-Open com.ibm.ws.jsp_fat_lWAS has been transformed for running on EE10 as well.

New tests: A new FAT bucket io.openliberty.pages.3.1.internal_fat has been added with specific tests for Pages 3.1

  • Pages 3.1 deprecated methods that override ELResolver.getFeatureDescriptors() as that method has been deprecated as of Expression Language 5.0 the equivalent EE10 feature for Expression Language. No specific pages test added for this but this is tested within Expression Language 5.0.
  • Pages 3.1 deprecated the jsp:plugin action and related actions as the associated HTML elements are no longer supported by any major browser. A test was added to verify that having this action is a no-op for pages-3.1 and up and that an appropriate log message appears in the trace.
  • Pages 3.1 deprecated the isThreadSafe page directive attribute as the related Servlet API interface SingleThreadModel has been removed as of the Servlet 6.0 specification. Test has been added to verify that trying to use the directive results in a server warning CWWJS0003W.
  • Pages 3.1 clarified that the EL environment within a JSP has a set of default imports consistent with the default imports for the scripting environment. Refactor the ScopedAttributeELResolver to remove the special handling for imports and unresolved variables. Tests were added to verify imports are appropriately available to the Expression Language scripting environment.
  • Pages 3.1 clarified the meaning of ‘scope’ in the context of scripting variables associated with custom actions. No tests added as this was just a spec clarification with no functional changes.
  • Pages 3.1 Added an option to raise a PropertyNotFoundException when an EL expression contains an unknown identifier. Tests were added to verify if a PropertyNotFoundException is thrown when the option is set.

Manual tests: None.

Confidence: 4 All feature tests have been passing with no EE10 failures since enabling the feature. The com.ibm.ws.jsp_fat bucket in WS-CD-Open contains additional Pages tests, but this bucket has not been transformed due to framework conflicts.

@ayoho
Copy link
Member

ayoho commented Feb 23, 2023

LGTM 👍

@ayoho ayoho closed this as completed Feb 23, 2023
@pnicolucci pnicolucci moved this to Completed Tasks in Web Tier Team May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants