From 2bd4e09e9922bf6e5702d2b4b30a1c209dbb6d2a Mon Sep 17 00:00:00 2001 From: sv3n Date: Thu, 22 Dec 2022 10:30:31 +0100 Subject: [PATCH] PHPStan: added missing returns (#2832) --- .../Catalog/Product/Attribute/Set/Grid.php | 12 +- .../Catalog/Product/Edit/Tab/Attributes.php | 6 +- .../Product/Edit/Tab/Super/Config/Simple.php | 6 + .../Block/Report/Customer/Accounts/Grid.php | 4 + .../Block/Report/Customer/Orders/Grid.php | 7 + .../Block/Report/Customer/Totals/Grid.php | 7 + .../core/Mage/Adminhtml/Block/Report/Grid.php | 7 +- .../Adminhtml/Block/Report/Product/Grid.php | 4 +- .../Block/Report/Product/Ordered/Grid.php | 6 +- .../Block/Report/Shopcart/Customer/Grid.php | 3 +- .../Adminhtml/Block/Review/Product/Grid.php | 4 +- .../Catalog/Product/Edit/Action/Attribute.php | 2 +- .../core/Mage/Adminhtml/Model/Session.php | 4 +- .../Api2/Block/Adminhtml/Attribute/Grid.php | 4 +- .../Catalog/Product/Edit/Tab/Attributes.php | 4 +- .../Adminhtml/Catalog/Product/Edit/Tabs.php | 4 +- .../Catalog/Model/Layer/Filter/Decimal.php | 2 +- .../Mage/Catalog/Model/Layer/Filter/Price.php | 2 +- app/code/core/Mage/Catalog/Model/Product.php | 4 +- .../Model/Resource/Stock/Item/Collection.php | 4 +- .../core/Mage/Core/Block/Template/Zend.php | 3 +- app/code/core/Mage/Core/Helper/Data.php | 2 +- app/code/core/Mage/Core/Model/App.php | 8 +- .../core/Mage/Core/Model/App/Emulation.php | 4 +- .../core/Mage/Dataflow/Model/Batch/Io.php | 2 +- .../Dataflow/Model/Convert/Parser/Csv.php | 8 + .../controllers/FileController.php | 4 +- .../Adminhtml/Oauth/AuthorizeController.php | 4 +- .../Oauth/controllers/InitiateController.php | 4 +- .../Oauth/controllers/TokenController.php | 4 +- app/code/core/Mage/Paypal/Model/Express.php | 5 +- .../controllers/AddController.php | 3 +- .../Mage/Sales/Block/Order/Creditmemo.php | 4 +- .../Block/Order/Email/Creditmemo/Items.php | 7 +- .../Sales/Block/Order/Email/Invoice/Items.php | 7 +- .../Block/Order/Email/Shipment/Items.php | 7 +- app/code/core/Mage/Sales/Block/Order/Info.php | 4 +- .../core/Mage/Sales/Block/Order/Invoice.php | 4 +- .../core/Mage/Sales/Block/Order/Print.php | 7 +- .../Sales/Block/Order/Print/Creditmemo.php | 8 +- .../Mage/Sales/Block/Order/Print/Invoice.php | 8 +- .../Mage/Sales/Block/Order/Print/Shipment.php | 4 +- .../core/Mage/Sales/Block/Order/Shipment.php | 4 +- app/code/core/Mage/Sales/Block/Order/View.php | 4 +- .../Address/Attribute/Backend/Region.php | 3 +- .../Resource/Carrier/Tablerate/Collection.php | 4 +- app/code/core/Mage/Tax/Helper/Data.php | 4 +- app/code/core/Mage/Tax/Model/Calculation.php | 6 +- app/code/core/Mage/Tax/Model/Config.php | 4 +- .../Tax/Model/Sales/Total/Quote/Discount.php | 3 +- .../core/Mage/Weee/Model/Total/Quote/Weee.php | 17 +- .../Mage/Wishlist/Block/Customer/Sharing.php | 3 +- .../Mage/Wishlist/Block/Customer/Wishlist.php | 3 +- .../Wishlist/controllers/IndexController.php | 6 +- lib/Varien/Io/File.php | 2 +- phpstan.dist.baseline.neon | 419 +----------------- 56 files changed, 173 insertions(+), 516 deletions(-) diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php index d74ec7dea5b..d4cc6e80a4d 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php @@ -48,25 +48,19 @@ protected function _prepareCollection() } /** - * @return void + * @return $this * @throws Exception */ protected function _prepareColumns() { - /*$this->addColumn('set_id', array( - 'header' => Mage::helper('catalog')->__('ID'), - 'align' => 'right', - 'sortable' => true, - 'width' => '50px', - 'index' => 'attribute_set_id', - ));*/ - $this->addColumn('set_name', [ 'header' => Mage::helper('catalog')->__('Set Name'), 'align' => 'left', 'sortable' => true, 'index' => 'attribute_set_name', ]); + + return $this; } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php index d15d4ac470a..b65cf2920cf 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php @@ -43,9 +43,7 @@ protected function _prepareLayout() } /** - * Prepare attributes form - * - * @return void + * @inheritDoc */ protected function _prepareForm() { @@ -140,6 +138,8 @@ protected function _prepareForm() $this->setForm($form); } + + return parent::_prepareForm(); } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php index c5492a77c3c..a2e90de669b 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php @@ -35,6 +35,10 @@ class Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Super_Config_Simple extends */ protected $_product = null; + /** + * @return $this + * @throws Mage_Core_Exception + */ protected function _prepareForm() { $form = new Varien_Data_Form(); @@ -173,6 +177,8 @@ protected function _prepareForm() ]); $this->setForm($form); + + return $this; } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Customer/Accounts/Grid.php b/app/code/core/Mage/Adminhtml/Block/Report/Customer/Accounts/Grid.php index 34c6b8af8f4..5836d22b59f 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Customer/Accounts/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Customer/Accounts/Grid.php @@ -34,10 +34,14 @@ public function __construct() $this->setId('gridAccounts'); } + /** + * @return $this + */ protected function _prepareCollection() { parent::_prepareCollection(); $this->getCollection()->initReport('reports/accounts_collection'); + return $this; } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Customer/Orders/Grid.php b/app/code/core/Mage/Adminhtml/Block/Report/Customer/Orders/Grid.php index af27cd68b02..7371b05f7ac 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Customer/Orders/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Customer/Orders/Grid.php @@ -34,12 +34,19 @@ public function __construct() $this->setId('gridOrdersCustomer'); } + /** + * @return $this + */ protected function _prepareCollection() { parent::_prepareCollection(); $this->getCollection()->initReport('reports/customer_orders_collection'); + return $this; } + /** + * @inheritDoc + */ protected function _prepareColumns() { $this->addColumn('name', [ diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Customer/Totals/Grid.php b/app/code/core/Mage/Adminhtml/Block/Report/Customer/Totals/Grid.php index 3866e364302..211bece5cfd 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Customer/Totals/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Customer/Totals/Grid.php @@ -34,12 +34,19 @@ public function __construct() $this->setId('gridTotalsCustomer'); } + /** + * @return $this + */ protected function _prepareCollection() { parent::_prepareCollection(); $this->getCollection()->initReport('reports/customer_totals_collection'); + return $this; } + /** + * @inheritDoc + */ protected function _prepareColumns() { $this->addColumn('name', [ diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Grid.php b/app/code/core/Mage/Adminhtml/Block/Report/Grid.php index d5d4f545e48..da1c84917c0 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Grid.php @@ -78,6 +78,9 @@ public function __construct() $this->setCountTotals(true); } + /** + * @return $this + */ protected function _prepareLayout() { $this->setChild( @@ -114,7 +117,7 @@ protected function _prepareColumns() } /** - * @return void + * @return $this */ protected function _prepareCollection() { @@ -201,6 +204,8 @@ protected function _prepareCollection() 'adminhtml_widget_grid_filter_collection', ['collection' => $this->getCollection(), 'filter_values' => $this->_filterValues] ); + + return $this; } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php b/app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php index ddfdea0ddbe..742baf80865 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php @@ -51,12 +51,14 @@ protected function _prepareCollection() } /** - * @return void + * @inheritDoc */ protected function _afterLoadCollection() { $totalObj = new Mage_Reports_Model_Totals(); $this->setTotals($totalObj->countTotals($this)); + + return parent::_afterLoadCollection(); } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Product/Ordered/Grid.php b/app/code/core/Mage/Adminhtml/Block/Report/Product/Ordered/Grid.php index e11c7b0d659..bf44e049065 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Product/Ordered/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Product/Ordered/Grid.php @@ -33,14 +33,18 @@ public function __construct() } /** - * @return void + * @return $this */ protected function _prepareCollection() { parent::_prepareCollection(); $this->getCollection()->initReport('reports/product_ordered_collection'); + return $this; } + /** + * @inheritDoc + */ protected function _prepareColumns() { $this->addColumn('name', [ diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php b/app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php index 0250b22e045..38ad68eb295 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php @@ -55,11 +55,12 @@ protected function _prepareCollection() } /** - * @return void + * @inheritDoc */ protected function _afterLoadCollection() { $this->getCollection()->addCartInfo(); + return parent::_afterLoadCollection(); } /** diff --git a/app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php b/app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php index ad464dffb10..fc5da132361 100644 --- a/app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php @@ -37,7 +37,7 @@ public function __construct() } /** - * @return void + * @return $this */ protected function _prepareColumns() { @@ -103,6 +103,8 @@ protected function _prepareColumns() ] ); } + + return $this; } /** diff --git a/app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php b/app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php index c6c60da9df5..5068229f829 100644 --- a/app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php +++ b/app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php @@ -75,7 +75,7 @@ public function getProducts() /** * Return array of selected product ids from post or session * - * @return string|null + * @return array|string|null */ public function getProductIds() { diff --git a/app/code/core/Mage/Adminhtml/Model/Session.php b/app/code/core/Mage/Adminhtml/Model/Session.php index 26d4ccdb7c3..5bfb2fbd4c8 100644 --- a/app/code/core/Mage/Adminhtml/Model/Session.php +++ b/app/code/core/Mage/Adminhtml/Model/Session.php @@ -26,8 +26,8 @@ * @package Mage_Adminhtml * @author Magento Core Team * - * @method string getProductIds() - * @method $this setProductIds(string $value) + * @method array|string getProductIds() + * @method $this setProductIds(array|string $value) */ class Mage_Adminhtml_Model_Session extends Mage_Core_Model_Session_Abstract { diff --git a/app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php b/app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php index f32df29e915..912cb7bc880 100644 --- a/app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php +++ b/app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php @@ -41,7 +41,7 @@ public function __construct($attributes = []) /** * Collection object set up - * @return void + * @return $this */ protected function _prepareCollection() { @@ -54,6 +54,8 @@ protected function _prepareCollection() } $this->setCollection($collection); + + return $this; } /** diff --git a/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php b/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php index 1057855e458..a0585057d29 100644 --- a/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php +++ b/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php @@ -33,7 +33,7 @@ class Mage_Bundle_Block_Adminhtml_Catalog_Product_Edit_Tab_Attributes extends Ma /** * Prepare attributes form of bundle product * - * @return void + * @return $this */ protected function _prepareForm() { @@ -155,6 +155,8 @@ function changePriceTypeMap() { . '' ); } + + return $this; } /** diff --git a/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php b/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php index 5114cd72f5b..b6570d1aed2 100644 --- a/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php +++ b/app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php @@ -31,7 +31,7 @@ class Mage_Bundle_Block_Adminhtml_Catalog_Product_Edit_Tabs extends Mage_Adminht protected $_attributeTabBlock = 'bundle/adminhtml_catalog_product_edit_tab_attributes'; /** - * @return void + * @return $this * @throws Exception */ protected function _prepareLayout() @@ -44,5 +44,7 @@ protected function _prepareLayout() 'class' => 'ajax', ]); $this->bindShadowTabs('bundle_items', 'customer_options'); + + return $this; } } diff --git a/app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php b/app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php index d2ce4547089..d43163df9b6 100644 --- a/app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php +++ b/app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php @@ -184,7 +184,7 @@ public function getRange() * Retrieve information about products count in range * * @param int $range - * @return int + * @return array */ public function getRangeItemCounts($range) { diff --git a/app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php b/app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php index 1b19cc2f49b..768dcd04106 100644 --- a/app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php +++ b/app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php @@ -142,7 +142,7 @@ public function getMaxPriceInt() * Get information about products count in range * * @param int $range - * @return int + * @return array */ public function getRangeItemCounts($range) { diff --git a/app/code/core/Mage/Catalog/Model/Product.php b/app/code/core/Mage/Catalog/Model/Product.php index c176a6a43ec..9affa87bc48 100644 --- a/app/code/core/Mage/Catalog/Model/Product.php +++ b/app/code/core/Mage/Catalog/Model/Product.php @@ -864,8 +864,8 @@ public function getGroupPrice() /** * Get product tier price by qty * - * @param double $qty - * @return double + * @param float $qty + * @return float|array */ public function getTierPrice($qty = null) { diff --git a/app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item/Collection.php b/app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item/Collection.php index 61fad0fb4a1..bf5ba5f74e4 100644 --- a/app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item/Collection.php +++ b/app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item/Collection.php @@ -137,9 +137,7 @@ public function addQtyFilter($comparsionMethod, $qty) } /** - * Initialize select object - * - * @return Varien_Db_Select + * @inheritDoc */ protected function _initSelect() { diff --git a/app/code/core/Mage/Core/Block/Template/Zend.php b/app/code/core/Mage/Core/Block/Template/Zend.php index 7970df5556e..5e4f168355b 100644 --- a/app/code/core/Mage/Core/Block/Template/Zend.php +++ b/app/code/core/Mage/Core/Block/Template/Zend.php @@ -62,11 +62,12 @@ public function assign($key, $value = null) /** * @param string $dir - * @return void + * @return $this */ public function setScriptPath($dir) { $this->_view->setScriptPath($dir . DS); + return $this; } /** diff --git a/app/code/core/Mage/Core/Helper/Data.php b/app/code/core/Mage/Core/Helper/Data.php index 80704388b36..2c78cd55116 100644 --- a/app/code/core/Mage/Core/Helper/Data.php +++ b/app/code/core/Mage/Core/Helper/Data.php @@ -389,7 +389,7 @@ public function removeAccents($string, $german = false) } /** - * @param int|null $storeId + * @param null|string|bool|int|Mage_Core_Model_Store $storeId * @return bool */ public function isDevAllowed($storeId = null) diff --git a/app/code/core/Mage/Core/Model/App.php b/app/code/core/Mage/Core/Model/App.php index 7c8251ffeda..f43bcc4112d 100644 --- a/app/code/core/Mage/Core/Model/App.php +++ b/app/code/core/Mage/Core/Model/App.php @@ -752,7 +752,7 @@ protected function _getStoreByWebsite($website) /** * Set current default store * - * @param string $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return $this */ public function setCurrentStore($store) @@ -936,7 +936,7 @@ protected function _getDefaultStore() /** * Retrieve default store for default group and website * - * @return Mage_Core_Model_Store + * @return Mage_Core_Model_Store|null */ public function getDefaultStoreView() { @@ -1431,6 +1431,10 @@ public function getUpdateMode() return $this->_updateMode; } + /** + * @param string $text + * @throws Mage_Core_Model_Store_Exception + */ public function throwStoreException($text = '') { throw new Mage_Core_Model_Store_Exception($text); diff --git a/app/code/core/Mage/Core/Model/App/Emulation.php b/app/code/core/Mage/Core/Model/App/Emulation.php index 8cd94fdf7a2..0529d0a006b 100644 --- a/app/code/core/Mage/Core/Model/App/Emulation.php +++ b/app/code/core/Mage/Core/Model/App/Emulation.php @@ -162,7 +162,7 @@ protected function _emulateDesign($storeId, $area = Mage_Core_Model_App_Area::AR /** * Apply locale of the specified store * - * @param int $storeId + * @param null|string|bool|int|Mage_Core_Model_Store $storeId * @param string $area * * @return string initial locale code @@ -182,7 +182,7 @@ protected function _emulateLocale($storeId, $area = Mage_Core_Model_App_Area::AR * Retrieve config value for store by path * * @param string $path - * @param mixed $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return mixed */ protected function _getStoreConfig($path, $store = null) diff --git a/app/code/core/Mage/Dataflow/Model/Batch/Io.php b/app/code/core/Mage/Dataflow/Model/Batch/Io.php index 84beee2969e..098d5b97999 100644 --- a/app/code/core/Mage/Dataflow/Model/Batch/Io.php +++ b/app/code/core/Mage/Dataflow/Model/Batch/Io.php @@ -159,7 +159,7 @@ public function write($string) * # length bytes have been read * # EOF (end of file) is reached * - * @return false|string + * @return array|false|null|string */ public function read($csv = false, $delimiter = ',', $enclosure = '"') { diff --git a/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php b/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php index 6c4baa044bf..ad9c0877c9c 100644 --- a/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php +++ b/app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php @@ -32,6 +32,10 @@ class Mage_Dataflow_Model_Convert_Parser_Csv extends Mage_Dataflow_Model_Convert protected $_mapfields = []; + /** + * @return $this + * @throws Throwable + */ public function parse() { // fixed for multibyte characters @@ -192,6 +196,10 @@ public function unparse() return $this; } + /** + * @param array $args + * @return string + */ public function unparseRow($args) { $i = $args['i']; diff --git a/app/code/core/Mage/Downloadable/controllers/FileController.php b/app/code/core/Mage/Downloadable/controllers/FileController.php index db88a3240a0..bc40b824115 100644 --- a/app/code/core/Mage/Downloadable/controllers/FileController.php +++ b/app/code/core/Mage/Downloadable/controllers/FileController.php @@ -35,10 +35,12 @@ class Mage_Downloadable_FileController extends Mage_Downloadable_Adminhtml_Downl * Controller pre-dispatch method * Show 404 front page * - * @return void + * @return $this */ public function preDispatch() { $this->_forward('defaultIndex', 'cms_index'); + + return $this; } } diff --git a/app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php b/app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php index dc10cfb32c3..7566839b903 100644 --- a/app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php +++ b/app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php @@ -46,7 +46,7 @@ class Mage_Oauth_Adminhtml_Oauth_AuthorizeController extends Mage_Adminhtml_Cont * Disable showing of login form * * @see Mage_Admin_Model_Observer::actionPreDispatchAdmin() method for explanation - * @return void + * @return $this */ public function preDispatch() { @@ -67,6 +67,8 @@ public function preDispatch() $params = ['_query' => ['oauth_token' => $this->getRequest()->getParam('oauth_token', null)]]; $this->_redirect('*/*/*', $params); } + + return $this; } /** diff --git a/app/code/core/Mage/Oauth/controllers/InitiateController.php b/app/code/core/Mage/Oauth/controllers/InitiateController.php index f8e8d8a0d5c..20e9d990998 100644 --- a/app/code/core/Mage/Oauth/controllers/InitiateController.php +++ b/app/code/core/Mage/Oauth/controllers/InitiateController.php @@ -29,7 +29,7 @@ class Mage_Oauth_InitiateController extends Mage_Core_Controller_Front_Action /** * Dispatch event before action * - * @return void + * @inheritDoc */ public function preDispatch() { @@ -38,7 +38,7 @@ public function preDispatch() $this->setFlag('', self::FLAG_NO_COOKIES_REDIRECT, 0); $this->setFlag('', self::FLAG_NO_PRE_DISPATCH, 1); - parent::preDispatch(); + return parent::preDispatch(); } /** diff --git a/app/code/core/Mage/Oauth/controllers/TokenController.php b/app/code/core/Mage/Oauth/controllers/TokenController.php index d004f5b0fc2..8556069e067 100644 --- a/app/code/core/Mage/Oauth/controllers/TokenController.php +++ b/app/code/core/Mage/Oauth/controllers/TokenController.php @@ -31,7 +31,7 @@ class Mage_Oauth_TokenController extends Mage_Core_Controller_Front_Action /** * Dispatch event before action * - * @return void + * @inheritDoc */ public function preDispatch() { @@ -40,7 +40,7 @@ public function preDispatch() $this->setFlag('', self::FLAG_NO_COOKIES_REDIRECT, 0); $this->setFlag('', self::FLAG_NO_PRE_DISPATCH, 1); - parent::preDispatch(); + return parent::preDispatch(); } /** diff --git a/app/code/core/Mage/Paypal/Model/Express.php b/app/code/core/Mage/Paypal/Model/Express.php index fc8a3779ecf..2627eaac5c6 100644 --- a/app/code/core/Mage/Paypal/Model/Express.php +++ b/app/code/core/Mage/Paypal/Model/Express.php @@ -540,10 +540,7 @@ public function updateRecurringProfileStatus(Mage_Payment_Model_Recurring_Profil } /** - * Assign data to info model instance - * - * @param mixed $data - * @return Mage_Payment_Model_Info + * @inheritDoc */ public function assignData($data) { diff --git a/app/code/core/Mage/ProductAlert/controllers/AddController.php b/app/code/core/Mage/ProductAlert/controllers/AddController.php index f1a9fba0eca..645b0a39049 100644 --- a/app/code/core/Mage/ProductAlert/controllers/AddController.php +++ b/app/code/core/Mage/ProductAlert/controllers/AddController.php @@ -29,7 +29,7 @@ class Mage_ProductAlert_AddController extends Mage_Core_Controller_Front_Action { /** - * @return void + * @return $this */ public function preDispatch() { @@ -41,6 +41,7 @@ public function preDispatch() Mage::getSingleton('customer/session')->setBeforeUrl($this->_getRefererUrl()); } } + return $this; } public function testObserverAction() diff --git a/app/code/core/Mage/Sales/Block/Order/Creditmemo.php b/app/code/core/Mage/Sales/Block/Order/Creditmemo.php index 2dd6f83c7d2..c396576c794 100644 --- a/app/code/core/Mage/Sales/Block/Order/Creditmemo.php +++ b/app/code/core/Mage/Sales/Block/Order/Creditmemo.php @@ -35,7 +35,7 @@ protected function _construct() } /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -51,6 +51,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** diff --git a/app/code/core/Mage/Sales/Block/Order/Email/Creditmemo/Items.php b/app/code/core/Mage/Sales/Block/Order/Email/Creditmemo/Items.php index 61d47a79edb..5fed355cc51 100644 --- a/app/code/core/Mage/Sales/Block/Order/Email/Creditmemo/Items.php +++ b/app/code/core/Mage/Sales/Block/Order/Email/Creditmemo/Items.php @@ -29,14 +29,13 @@ class Mage_Sales_Block_Order_Email_Creditmemo_Items extends Mage_Sales_Block_Items_Abstract { /** - * Prepare item before output - * - * @param Mage_Core_Block_Abstract $renderer - * @return void + * @inheritDoc */ protected function _prepareItem(Mage_Core_Block_Abstract $renderer) { $renderer->getItem()->setOrder($this->getOrder()); $renderer->getItem()->setSource($this->getCreditmemo()); + + return parent::_prepareItem($renderer); } } diff --git a/app/code/core/Mage/Sales/Block/Order/Email/Invoice/Items.php b/app/code/core/Mage/Sales/Block/Order/Email/Invoice/Items.php index 90420b51615..458fa4cb960 100644 --- a/app/code/core/Mage/Sales/Block/Order/Email/Invoice/Items.php +++ b/app/code/core/Mage/Sales/Block/Order/Email/Invoice/Items.php @@ -29,14 +29,13 @@ class Mage_Sales_Block_Order_Email_Invoice_Items extends Mage_Sales_Block_Items_Abstract { /** - * Prepare item before output - * - * @param Mage_Core_Block_Abstract $renderer - * @return void + * @inheritDoc */ protected function _prepareItem(Mage_Core_Block_Abstract $renderer) { $renderer->getItem()->setOrder($this->getOrder()); $renderer->getItem()->setSource($this->getInvoice()); + + return parent::_prepareItem($renderer); } } diff --git a/app/code/core/Mage/Sales/Block/Order/Email/Shipment/Items.php b/app/code/core/Mage/Sales/Block/Order/Email/Shipment/Items.php index 940195a40dd..4776205cdd8 100644 --- a/app/code/core/Mage/Sales/Block/Order/Email/Shipment/Items.php +++ b/app/code/core/Mage/Sales/Block/Order/Email/Shipment/Items.php @@ -29,14 +29,13 @@ class Mage_Sales_Block_Order_Email_Shipment_Items extends Mage_Sales_Block_Items_Abstract { /** - * Prepare item before output - * - * @param Mage_Core_Block_Abstract $renderer - * @return void + * @inheritDoc */ protected function _prepareItem(Mage_Core_Block_Abstract $renderer) { $renderer->getItem()->setOrder($this->getOrder()); $renderer->getItem()->setSource($this->getShipment()); + + return parent::_prepareItem($renderer); } } diff --git a/app/code/core/Mage/Sales/Block/Order/Info.php b/app/code/core/Mage/Sales/Block/Order/Info.php index 4391b2e44c7..cdb6c5e3bd0 100644 --- a/app/code/core/Mage/Sales/Block/Order/Info.php +++ b/app/code/core/Mage/Sales/Block/Order/Info.php @@ -37,7 +37,7 @@ protected function _construct() } /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -53,6 +53,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** diff --git a/app/code/core/Mage/Sales/Block/Order/Invoice.php b/app/code/core/Mage/Sales/Block/Order/Invoice.php index cd3db6dc774..4420fc34858 100644 --- a/app/code/core/Mage/Sales/Block/Order/Invoice.php +++ b/app/code/core/Mage/Sales/Block/Order/Invoice.php @@ -35,7 +35,7 @@ protected function _construct() } /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -51,6 +51,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** diff --git a/app/code/core/Mage/Sales/Block/Order/Print.php b/app/code/core/Mage/Sales/Block/Order/Print.php index 1398c773550..985c786860a 100644 --- a/app/code/core/Mage/Sales/Block/Order/Print.php +++ b/app/code/core/Mage/Sales/Block/Order/Print.php @@ -29,7 +29,7 @@ class Mage_Sales_Block_Order_Print extends Mage_Sales_Block_Items_Abstract { /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -45,6 +45,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** @@ -56,7 +58,7 @@ public function getPaymentInfoHtml() } /** - * @return mixed + * @return Mage_Sales_Model_Order */ public function getOrder() { @@ -70,7 +72,6 @@ public function getOrder() protected function _prepareItem(Mage_Core_Block_Abstract $renderer) { $renderer->setPrintStatus(true); - return parent::_prepareItem($renderer); } } diff --git a/app/code/core/Mage/Sales/Block/Order/Print/Creditmemo.php b/app/code/core/Mage/Sales/Block/Order/Print/Creditmemo.php index 1a16c66d4cc..b1909b75768 100644 --- a/app/code/core/Mage/Sales/Block/Order/Print/Creditmemo.php +++ b/app/code/core/Mage/Sales/Block/Order/Print/Creditmemo.php @@ -29,7 +29,7 @@ class Mage_Sales_Block_Order_Print_Creditmemo extends Mage_Sales_Block_Items_Abstract { /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -45,6 +45,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** @@ -72,7 +74,7 @@ public function getPaymentInfoHtml() } /** - * @return mixed + * @return Mage_Sales_Model_Order */ public function getOrder() { @@ -80,7 +82,7 @@ public function getOrder() } /** - * @return mixed + * @return Mage_Sales_Model_Order_Invoice */ public function getCreditmemo() { diff --git a/app/code/core/Mage/Sales/Block/Order/Print/Invoice.php b/app/code/core/Mage/Sales/Block/Order/Print/Invoice.php index ae4c8427bca..75ecfe078b4 100644 --- a/app/code/core/Mage/Sales/Block/Order/Print/Invoice.php +++ b/app/code/core/Mage/Sales/Block/Order/Print/Invoice.php @@ -29,7 +29,7 @@ class Mage_Sales_Block_Order_Print_Invoice extends Mage_Sales_Block_Items_Abstract { /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -45,6 +45,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** @@ -72,7 +74,7 @@ public function getPaymentInfoHtml() } /** - * @return mixed + * @return Mage_Sales_Model_Order */ public function getOrder() { @@ -80,7 +82,7 @@ public function getOrder() } /** - * @return mixed + * @return Mage_Sales_Model_Order_Invoice */ public function getInvoice() { diff --git a/app/code/core/Mage/Sales/Block/Order/Print/Shipment.php b/app/code/core/Mage/Sales/Block/Order/Print/Shipment.php index 45908944977..29f714230a3 100644 --- a/app/code/core/Mage/Sales/Block/Order/Print/Shipment.php +++ b/app/code/core/Mage/Sales/Block/Order/Print/Shipment.php @@ -67,7 +67,7 @@ protected function _beforeToHtml() } /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -83,6 +83,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** diff --git a/app/code/core/Mage/Sales/Block/Order/Shipment.php b/app/code/core/Mage/Sales/Block/Order/Shipment.php index 763c73f5ae6..774a19f6296 100644 --- a/app/code/core/Mage/Sales/Block/Order/Shipment.php +++ b/app/code/core/Mage/Sales/Block/Order/Shipment.php @@ -35,7 +35,7 @@ protected function _construct() } /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -51,6 +51,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** diff --git a/app/code/core/Mage/Sales/Block/Order/View.php b/app/code/core/Mage/Sales/Block/Order/View.php index 660817d4a1d..6a70cdfead0 100644 --- a/app/code/core/Mage/Sales/Block/Order/View.php +++ b/app/code/core/Mage/Sales/Block/Order/View.php @@ -35,7 +35,7 @@ protected function _construct() } /** - * @return void + * @inheritDoc */ protected function _prepareLayout() { @@ -51,6 +51,8 @@ protected function _prepareLayout() 'payment_info', $helper->getInfoBlock($this->getOrder()->getPayment()) ); + + return parent::_prepareLayout(); } /** diff --git a/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php b/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php index d8a1b14c1a6..a28a2af6d49 100644 --- a/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php +++ b/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php @@ -28,7 +28,7 @@ class Mage_Sales_Model_Entity_Quote_Address_Attribute_Backend_Region extends Mag { /** * @param Varien_Object|Mage_Sales_Model_Quote_Address $object - * @return void + * @return $this */ public function beforeSave($object) { @@ -39,5 +39,6 @@ public function beforeSave($object) $object->setRegion($region->getCode()); } } + return $this; } } diff --git a/app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate/Collection.php b/app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate/Collection.php index 6e9dd044a0f..41d48f576bc 100644 --- a/app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate/Collection.php +++ b/app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate/Collection.php @@ -65,7 +65,7 @@ protected function _construct() /** * Initialize select, add country iso3 code and region name * - * @return void + * @return $this */ public function _initSelect() { @@ -87,6 +87,8 @@ public function _initSelect() $this->addOrder('dest_region', self::SORT_ORDER_ASC); $this->addOrder('dest_zip', self::SORT_ORDER_ASC); $this->addOrder('condition_value', self::SORT_ORDER_ASC); + + return $this; } /** diff --git a/app/code/core/Mage/Tax/Helper/Data.php b/app/code/core/Mage/Tax/Helper/Data.php index 45db7bfdbd6..308dced7f9e 100644 --- a/app/code/core/Mage/Tax/Helper/Data.php +++ b/app/code/core/Mage/Tax/Helper/Data.php @@ -907,7 +907,7 @@ public function joinTaxClass($select, $storeId, $priceTable = 'main_table') /** * Get configuration setting "Apply Discount On Prices Including Tax" value * - * @param null|int $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return bool 0|1 */ public function discountTax($store = null) @@ -1207,7 +1207,7 @@ public function isConflictingFptTaxConfigurationSettingsIgnored() /** * Return whether cross border trade is enabled or not * - * @param null|int $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return bool */ public function isCrossBorderTradeEnabled($store = null) diff --git a/app/code/core/Mage/Tax/Model/Calculation.php b/app/code/core/Mage/Tax/Model/Calculation.php index 4fb0803b222..7b7a73d85ca 100644 --- a/app/code/core/Mage/Tax/Model/Calculation.php +++ b/app/code/core/Mage/Tax/Model/Calculation.php @@ -347,7 +347,7 @@ public function getStoreRateForItem($item, $store = null) /** * Get request object for getting tax rate based on store shippig original address * - * @param null|Mage_Core_Model_Store $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return Varien_Object */ public function getRateOriginRequest($store = null) @@ -364,7 +364,7 @@ public function getRateOriginRequest($store = null) /** * Return the default rate request. It can be either based on store address or customer address * - * @param null|Mage_Core_Model_Store $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return Varien_Object */ public function getDefaultRateRequest($store = null) @@ -389,7 +389,7 @@ public function getDefaultRateRequest($store = null) * @param null|false|Mage_Sales_Model_Quote_Address $shippingAddress * @param null|false|Mage_Sales_Model_Quote_Address $billingAddress * @param null|int $customerTaxClass - * @param null|int $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return Varien_Object */ public function getRateRequest( diff --git a/app/code/core/Mage/Tax/Model/Config.php b/app/code/core/Mage/Tax/Model/Config.php index ea8fa70a47f..4d911ec9680 100644 --- a/app/code/core/Mage/Tax/Model/Config.php +++ b/app/code/core/Mage/Tax/Model/Config.php @@ -198,7 +198,7 @@ public function getPriceDisplayType($store = null) /** * Get configuration setting "Apply Discount On Prices Including Tax" value * - * @param null|int $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return bool 0|1 */ public function discountTax($store = null) @@ -751,7 +751,7 @@ public function checkDiscountSettings($store = null) /** * Return the config value for self::CONFIG_XML_PATH_CROSS_BORDER_TRADE_ENABLED * - * @param int|null $store + * @param null|string|bool|int|Mage_Core_Model_Store $store * @return int */ public function crossBorderTradeEnabled($store = null) diff --git a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php index df6f0f90e84..e97f1db6546 100644 --- a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php +++ b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php @@ -32,9 +32,10 @@ class Mage_Tax_Model_Sales_Total_Quote_Discount extends Mage_Sales_Model_Quote_A * Calculate discount tac amount * * @param Mage_Sales_Model_Quote_Address $address - * @return void + * @return $this */ public function collect(Mage_Sales_Model_Quote_Address $address) { + return $this; } } diff --git a/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php b/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php index 04d8b57f18e..f821c263e71 100644 --- a/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php +++ b/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php @@ -70,7 +70,7 @@ public function __construct() * Collect Weee taxes amount and prepare items prices for taxation and discount * * @param Mage_Sales_Model_Quote_Address $address - * @return Mage_Weee_Model_Total_Quote_Weee + * @return $this */ public function collect(Mage_Sales_Model_Quote_Address $address) { @@ -116,7 +116,7 @@ public function collect(Mage_Sales_Model_Quote_Address $address) * * @param Mage_Sales_Model_Quote_Address $address * @param Mage_Sales_Model_Quote_Item_Abstract $item - * @return Mage_Weee_Model_Total_Quote_Weee + * @return $this */ protected function _process(Mage_Sales_Model_Quote_Address $address, $item) { @@ -275,7 +275,7 @@ protected function _customerRatePercent($address, $item) * @param Mage_Sales_Model_Quote_Item_Abstract $item * @param float $value * @param float $baseValue - * @return Mage_Weee_Model_Total_Quote_Weee + * @return $this */ protected function _processDiscountSettings($item, $value, $baseValue) { @@ -293,7 +293,7 @@ protected function _processDiscountSettings($item, $value, $baseValue) * @param float $baseValue * @param float $rowValue * @param float $baseRowValue - * @return Mage_Weee_Model_Total_Quote_Weee + * @return $this */ protected function _processTaxSettings($item, $value, $baseValue, $rowValue, $baseRowValue) { @@ -323,7 +323,7 @@ protected function _processTaxSettings($item, $value, $baseValue, $rowValue, $ba * @param Mage_Sales_Model_Quote_Address $address * @param float $rowValue * @param float $baseRowValue - * @return Mage_Weee_Model_Total_Quote_Weee + * @return $this */ protected function _processTotalAmount($address, $rowValue, $baseRowValue) { @@ -342,10 +342,11 @@ protected function _processTotalAmount($address, $rowValue, $baseRowValue) * Recalculate parent item amounts based on children results * * @param Mage_Sales_Model_Quote_Item_Abstract $item - * @return void + * @return $this */ protected function _recalculateParent(Mage_Sales_Model_Quote_Item_Abstract $item) { + return $this; } /** @@ -374,7 +375,7 @@ protected function _resetItemData($item) * Fetch FPT data to address object for display in totals block * * @param Mage_Sales_Model_Quote_Address $address - * @return Mage_Weee_Model_Total_Quote_Weee + * @return $this */ public function fetch(Mage_Sales_Model_Quote_Address $address) { @@ -401,7 +402,7 @@ public function processConfigArray($config, $store) * @param Mage_Sales_Model_Quote_Address $address * @param Mage_Sales_Model_Quote_Item_Abstract $item * @param bool $updateParent - * @return Mage_Weee_Model_Total_Quote_Weee + * @return $this */ protected function _processItem(Mage_Sales_Model_Quote_Address $address, $item, $updateParent = false) { diff --git a/app/code/core/Mage/Wishlist/Block/Customer/Sharing.php b/app/code/core/Mage/Wishlist/Block/Customer/Sharing.php index 26f1d4d8984..a6231324f26 100644 --- a/app/code/core/Mage/Wishlist/Block/Customer/Sharing.php +++ b/app/code/core/Mage/Wishlist/Block/Customer/Sharing.php @@ -38,7 +38,7 @@ class Mage_Wishlist_Block_Customer_Sharing extends Mage_Core_Block_Template /** * Prepare Global Layout * - * @return void + * @return $this */ protected function _prepareLayout() { @@ -46,6 +46,7 @@ protected function _prepareLayout() if ($headBlock) { $headBlock->setTitle($this->__('Wishlist Sharing')); } + return $this; } /** diff --git a/app/code/core/Mage/Wishlist/Block/Customer/Wishlist.php b/app/code/core/Mage/Wishlist/Block/Customer/Wishlist.php index 98f2c1c0be5..8e4d62c9674 100644 --- a/app/code/core/Mage/Wishlist/Block/Customer/Wishlist.php +++ b/app/code/core/Mage/Wishlist/Block/Customer/Wishlist.php @@ -48,7 +48,7 @@ protected function _prepareCollection($collection) /** * Preparing global layout * - * @return void + * @return $this */ protected function _prepareLayout() { @@ -57,6 +57,7 @@ protected function _prepareLayout() if ($headBlock) { $headBlock->setTitle($this->__('My Wishlist')); } + return $this; } /** diff --git a/app/code/core/Mage/Wishlist/controllers/IndexController.php b/app/code/core/Mage/Wishlist/controllers/IndexController.php index fd67e52b211..2cb68af2804 100644 --- a/app/code/core/Mage/Wishlist/controllers/IndexController.php +++ b/app/code/core/Mage/Wishlist/controllers/IndexController.php @@ -48,7 +48,7 @@ class Mage_Wishlist_IndexController extends Mage_Wishlist_Controller_Abstract /** * Extend preDispatch * - * @return void + * @return $this|void */ public function preDispatch() { @@ -65,6 +65,7 @@ public function preDispatch() $this->norouteAction(); return; } + return $this; } /** @@ -81,7 +82,7 @@ public function skipAuthentication() /** * Retrieve wishlist object * @param int $wishlistId - * @return Mage_Wishlist_Model_Wishlist|bool + * @return Mage_Wishlist_Model_Wishlist|false */ protected function _getWishlist($wishlistId = null) { @@ -95,7 +96,6 @@ protected function _getWishlist($wishlistId = null) $wishlistId = $this->getRequest()->getParam('wishlist_id'); } $customerId = Mage::getSingleton('customer/session')->getCustomerId(); - /** @var Mage_Wishlist_Model_Wishlist $wishlist */ $wishlist = Mage::getModel('wishlist/wishlist'); if ($wishlistId) { $wishlist->load($wishlistId); diff --git a/lib/Varien/Io/File.php b/lib/Varien/Io/File.php index 088e8f13303..e9536e7cd81 100644 --- a/lib/Varien/Io/File.php +++ b/lib/Varien/Io/File.php @@ -195,7 +195,7 @@ public function streamRead($length = 1024) /** * Gets line from file pointer and parse for CSV fields * - * @return bool|string + * @return array|false|null */ public function streamReadCsv($delimiter = ',', $enclosure = '"') { diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon index 7223e25a5ee..2ac0bdf619c 100644 --- a/phpstan.dist.baseline.neon +++ b/phpstan.dist.baseline.neon @@ -140,11 +140,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Grid.php - - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Catalog_Product_Attribute_Set_Grid\\:\\:_prepareColumns\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareColumns\\(\\)$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php - - message: "#^Parameter \\#1 \\$attributeId of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getAttributeById\\(\\) expects int, string given\\.$#" count: 1 @@ -175,11 +170,6 @@ parameters: count: 4 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php - - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Attributes\\:\\:_prepareForm\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Form\\)\\) of method Mage_Adminhtml_Block_Widget_Form\\:\\:_prepareForm\\(\\)$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Attributes.php - - message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" count: 1 @@ -510,11 +500,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Grid\\:\\:_prepareCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareCollection\\(\\)$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Call to an undefined method Mage_Reports_Model_Resource_Report_Collection_Abstract\\:\\:addOrderStatusFilter\\(\\)\\.$#" count: 1 @@ -575,11 +560,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php - - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Product_Grid\\:\\:_afterLoadCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_afterLoadCollection\\(\\)$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Report/Product/Grid.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Reports_Model_Resource_Product_Lowstock_Collection given\\.$#" count: 1 @@ -625,11 +605,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php - - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Report_Shopcart_Customer_Grid\\:\\:_afterLoadCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_afterLoadCollection\\(\\)$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Report/Shopcart/Customer/Grid.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Tag_Model_Resource_Product_Collection given\\.$#" count: 1 @@ -685,11 +660,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php - - - message: "#^Return type \\(void\\) of method Mage_Adminhtml_Block_Review_Product_Grid\\:\\:_prepareColumns\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Catalog_Product_Grid\\:\\:_prepareColumns\\(\\)$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php - - message: "#^Parameter \\#1 \\$storeId of method Mage_Rating_Model_Resource_Rating_Collection\\:\\:setStoreFilter\\(\\) expects int, array given\\.$#" count: 1 @@ -785,11 +755,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Header.php - - - message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php - - message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" count: 1 @@ -1230,11 +1195,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Controller/Sales/Shipment.php - - - message: "#^Call to function is_array\\(\\) with string\\|null will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Helper/Catalog/Product/Edit/Action/Attribute.php - - message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Product_Collection will always evaluate to false\\.$#" count: 1 @@ -1425,31 +1385,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/System/Store.php - - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php - - - - message: "#^Call to function is_array\\(\\) with string\\|null will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php - - - - message: "#^Parameter \\#1 \\$productIds of method Mage_Catalog_Model_Product_Action\\:\\:updateAttributes\\(\\) expects array, string\\|null given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php - - - - message: "#^Parameter \\#1 \\$productIds of method Mage_Catalog_Model_Product_Action\\:\\:updateWebsites\\(\\) expects array, string\\|null given\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php - - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, string\\|null given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php - - message: "#^Return type \\(Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute\\) of method Mage_Adminhtml_Catalog_Product_Action_AttributeController\\:\\:_getHelper\\(\\) should be compatible with return type \\(Mage_Adminhtml_Helper_Data\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getHelper\\(\\)$#" count: 1 @@ -1845,11 +1780,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php - - - message: "#^Return type \\(void\\) of method Mage_Api2_Block_Adminhtml_Attribute_Grid\\:\\:_prepareCollection\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Block_Widget_Grid\\)\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:_prepareCollection\\(\\)$#" - count: 1 - path: app/code/core/Mage/Api2/Block/Adminhtml/Attribute/Grid.php - - message: "#^Property Mage_Api2_Block_Adminhtml_Attribute_Tab_Resource\\:\\:\\$_treeModel \\(Mage_Api2_Model_Acl_Global_Rule_Tree\\) does not accept default value of type false\\.$#" count: 1 @@ -2205,11 +2135,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option/Selection.php - - - message: "#^Return type \\(void\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Edit_Tabs\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tabs\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php - - message: "#^Parameter \\#4 \\$cond of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:joinTable\\(\\) expects array\\|null, string given\\.$#" count: 1 @@ -2750,11 +2675,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Helper/Product/Flat.php - - - message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Helper/Product/Type/Composite.php - - message: "#^Parameter \\#3 \\$subject of function str_replace expects array\\|string, float given\\.$#" count: 1 @@ -2780,11 +2700,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Api/Resource.php - - - message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php - - message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product will always evaluate to false\\.$#" count: 1 @@ -2795,21 +2710,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php - - message: "#^Parameter \\#2 \\$billingAddress of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects Mage_Sales_Model_Quote_Address\\|false\\|null, Mage_Customer_Model_Address\\|null given\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -3035,11 +2940,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Layer/Filter/Category.php - - - message: "#^Argument of an invalid type int supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php - - message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Layer_Filter_Decimal will always evaluate to false\\.$#" count: 1 @@ -3055,11 +2955,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, int given\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php - - message: "#^Parameter \\#2 \\$filterBlock \\(Mage_Catalog_Block_Layer_Filter_Decimal\\) of method Mage_Catalog_Model_Layer_Filter_Decimal\\:\\:apply\\(\\) should be compatible with parameter \\$filterBlock \\(null\\) of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\)$#" count: 1 @@ -3085,31 +2980,16 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Layer/Filter/Decimal.php - - - message: "#^Argument of an invalid type int\\\\|int\\<1, max\\> supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php - - message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Layer_Filter_Price will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php - - - message: "#^Parameter \\#1 \\$array of function array_keys expects array, int\\\\|int\\<1, max\\> given\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php - - message: "#^Parameter \\#1 \\$string of function strlen expects string, float given\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, int given\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php - - message: "#^Parameter \\#3 \\$lowerPrice of method Mage_Catalog_Model_Layer_Filter_Price\\:\\:loadPreviousPrices\\(\\) expects int\\|null, float\\|null given\\.$#" count: 1 @@ -3450,11 +3330,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Type/Grouped/Price.php - - - message: "#^Call to function is_array\\(\\) with float will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Type/Price.php - - message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" count: 1 @@ -3465,11 +3340,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Type/Price.php - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, float given\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Type/Price.php - - message: "#^Parameter \\#2 \\$qty of method Mage_Catalog_Model_Product_Type_Price\\:\\:_applyOptionsPrice\\(\\) expects int, float\\|null given\\.$#" count: 1 @@ -3600,11 +3470,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php - - - message: "#^Strict comparison using \\=\\=\\= between Mage_Core_Model_Store and null will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getMainStoreTable\\(\\)\\.$#" count: 1 @@ -4281,7 +4146,7 @@ parameters: path: app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item.php - - message: "#^Return type \\(Varien_Db_Select\\) of method Mage_CatalogInventory_Model_Resource_Stock_Item_Collection\\:\\:_initSelect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Collection_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_initSelect\\(\\)$#" + message: "#^Method Mage_CatalogInventory_Model_Resource_Stock_Item_Collection\\:\\:_initSelect\\(\\) should return \\$this\\(Mage_CatalogInventory_Model_Resource_Stock_Item_Collection\\) but returns Varien_Db_Select\\.$#" count: 1 path: app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item/Collection.php @@ -4735,11 +4600,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Block/Template.php - - - message: "#^Return type \\(void\\) of method Mage_Core_Block_Template_Zend\\:\\:setScriptPath\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Template\\)\\) of method Mage_Core_Block_Template\\:\\:setScriptPath\\(\\)$#" - count: 1 - path: app/code/core/Mage/Core/Block/Template/Zend.php - - message: "#^Parameter \\#1 \\$name of method Mage_Core_Block_Abstract\\:\\:setAttribute\\(\\) expects string, array\\ given\\.$#" count: 1 @@ -4830,11 +4690,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Router/Admin.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_App\\:\\:setCurrentStore\\(\\) expects string, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Router/Default.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -4906,7 +4761,7 @@ parameters: path: app/code/core/Mage/Core/Model/App.php - - message: "#^Method Mage_Core_Model_App\\:\\:getDefaultStoreView\\(\\) should return Mage_Core_Model_Store but returns null\\.$#" + message: "#^Method Mage_Core_Model_App\\:\\:getAnyStoreView\\(\\) should return Mage_Core_Model_Store but return statement is missing\\.$#" count: 1 path: app/code/core/Mage/Core/Model/App.php @@ -4965,21 +4820,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/App.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/App.php - - message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" count: 1 path: app/code/core/Mage/Core/Model/App.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_App\\:\\:setCurrentStore\\(\\) expects string, int given\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/App/Emulation.php - - message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 @@ -5635,11 +5480,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Translate/Inline.php - - - message: "#^Parameter \\#1 \\$storeId of method Mage_Core_Helper_Data\\:\\:isDevAllowed\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Translate/Inline.php - - message: "#^Parameter \\#3 \\$storeId of method Mage_Core_Model_Resource_Translate_String\\:\\:deleteTranslate\\(\\) expects int\\|null, false given\\.$#" count: 1 @@ -6155,21 +5995,6 @@ parameters: count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Abstract.php - - - message: "#^Argument of an invalid type string\\|false supplied for foreach, only iterables are supported\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php - - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, string given\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php - - - - message: "#^Strict comparison using \\=\\=\\= between string and null will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php - - message: "#^Call to function is_null\\(\\) with SimpleXMLElement will always evaluate to false\\.$#" count: 1 @@ -6315,11 +6140,6 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/controllers/DownloadController.php - - - message: "#^Return type \\(void\\) of method Mage_Downloadable_FileController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Controller_Action\\)\\) of method Mage_Adminhtml_Controller_Action\\:\\:preDispatch\\(\\)$#" - count: 1 - path: app/code/core/Mage/Downloadable/controllers/FileController.php - - message: "#^Return type \\(void\\) of method Mage_Downloadable_Product_EditController\\:\\:preDispatch\\(\\) should be compatible with return type \\(Mage_Adminhtml_Controller_Action\\) of method Mage_Adminhtml_Catalog_ProductController\\:\\:preDispatch\\(\\)$#" count: 1 @@ -7420,11 +7240,6 @@ parameters: count: 4 path: app/code/core/Mage/Oauth/Model/Resource/Token/Collection.php - - - message: "#^Return type \\(void\\) of method Mage_Oauth_Adminhtml_Oauth_AuthorizeController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Controller_Action\\)\\) of method Mage_Adminhtml_Controller_Action\\:\\:preDispatch\\(\\)$#" - count: 1 - path: app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php - - message: "#^Parameter \\#1 \\$data of method Mage_Oauth_Adminhtml_Oauth_ConsumerController\\:\\:_setFormData\\(\\) expects array, null given\\.$#" count: 2 @@ -7455,16 +7270,6 @@ parameters: count: 1 path: app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - - message: "#^Return type \\(void\\) of method Mage_Oauth_InitiateController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" - count: 1 - path: app/code/core/Mage/Oauth/controllers/InitiateController.php - - - - message: "#^Return type \\(void\\) of method Mage_Oauth_TokenController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" - count: 1 - path: app/code/core/Mage/Oauth/controllers/TokenController.php - - message: "#^Method Mage_PageCache_Helper_Data\\:\\:getCacheControlInstance\\(\\) should return Mage_PageCache_Model_Control_Interface but returns Mage_Core_Model_Abstract\\.$#" count: 1 @@ -7775,11 +7580,6 @@ parameters: count: 2 path: app/code/core/Mage/Paypal/Model/Express.php - - - message: "#^Method Mage_Paypal_Model_Express\\:\\:assignData\\(\\) should return Mage_Payment_Model_Info but returns \\$this\\(Mage_Paypal_Model_Express\\)\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Parameter \\#1 \\$amount of method Mage_Paypal_Model_Express\\:\\:_callDoAuthorize\\(\\) expects int, float given\\.$#" count: 2 @@ -7800,11 +7600,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Express.php - - - message: "#^Return type \\(Mage_Payment_Model_Info\\) of method Mage_Paypal_Model_Express\\:\\:assignData\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Abstract\\)\\) of method Mage_Payment_Model_Method_Abstract\\:\\:assignData\\(\\)$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Cannot call method getData\\(\\) on array\\.$#" count: 2 @@ -8070,21 +7865,11 @@ parameters: count: 1 path: app/code/core/Mage/ProductAlert/Model/Observer.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_App\\:\\:setCurrentStore\\(\\) expects string, Mage_Core_Model_Store given\\.$#" - count: 4 - path: app/code/core/Mage/ProductAlert/Model/Observer.php - - message: "#^Method Mage_ProductAlert_Model_Observer\\:\\:process\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - - message: "#^Return type \\(void\\) of method Mage_ProductAlert_AddController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" - count: 1 - path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - message: "#^Method Mage_Rating_Model_Resource_Rating\\:\\:getEntityIdByCode\\(\\) should return int but returns string\\.$#" count: 1 @@ -8575,76 +8360,16 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Block/Order/Comments.php - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Creditmemo\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Creditmemo.php - - message: "#^Call to method setOrderFilter\\(\\) on an unknown class Mage_Sales_Model_Resource_Invoice_Collection\\.$#" count: 1 path: app/code/core/Mage/Sales/Block/Order/Details.php - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Creditmemo_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Email/Creditmemo/Items.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Invoice_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Email/Invoice/Items.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Email_Shipment_Items\\:\\:_prepareItem\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Block_Items_Abstract\\)\\) of method Mage_Sales_Block_Items_Abstract\\:\\:_prepareItem\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Email/Shipment/Items.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Info\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Info.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Invoice\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Invoice.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Print.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Creditmemo\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Print/Creditmemo.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Invoice\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Print/Invoice.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Print_Shipment\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Print/Shipment.php - - message: "#^Parameter \\#1 \\$size of method Varien_Data_Collection\\:\\:setPageSize\\(\\) expects int, string given\\.$#" count: 1 path: app/code/core/Mage/Sales/Block/Order/Recent.php - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_Shipment\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Shipment.php - - - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_View\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/View.php - - message: "#^Property Mage_Sales_Block_Recurring_Profiles\\:\\:\\$_profiles \\(Mage_Sales_Model_Resource_Recurring_Profile_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" count: 1 @@ -8860,11 +8585,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Entity/Quote/Address.php - - - message: "#^Return type \\(void\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Backend_Region\\:\\:beforeSave\\(\\) should be compatible with return type \\(\\$this\\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\)\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:beforeSave\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 @@ -9495,11 +9215,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Tax\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 @@ -9535,11 +9250,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:discountTax\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Parameter \\#1 \\$value of method Mage_Sales_Model_Quote_Item_Abstract\\:\\:setConvertedPrice\\(\\) expects float, null given\\.$#" count: 1 @@ -9880,11 +9590,6 @@ parameters: count: 2 path: app/code/core/Mage/SalesRule/Model/Validator.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Validator.php - - message: "#^Parameter \\#4 \\$value of method Mage_Weee_Helper_Data\\:\\:setWeeeTaxesAppliedProperty\\(\\) expects string, \\(float\\|int\\) given\\.$#" count: 2 @@ -9960,26 +9665,11 @@ parameters: count: 3 path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - - message: "#^Parameter \\#1 \\$row of method Mage_Shipping_Model_Resource_Carrier_Tablerate\\:\\:_getImportRow\\(\\) expects array, string\\|true given\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, string\\|true given\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 2 path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - - message: "#^Return type \\(void\\) of method Mage_Shipping_Model_Resource_Carrier_Tablerate_Collection\\:\\:_initSelect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Collection_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_initSelect\\(\\)$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate/Collection.php - - message: "#^Comparison operation \"\\<\" between \\(array\\|float\\|int\\) and float results in an error\\.$#" count: 1 @@ -10145,11 +9835,6 @@ parameters: count: 2 path: app/code/core/Mage/Tax/Helper/Data.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Parameter \\#2 \\$billingAddress of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects Mage_Sales_Model_Quote_Address\\|false\\|null, Mage_Customer_Model_Address\\|null given\\.$#" count: 2 @@ -10160,31 +9845,11 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Helper/Data.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Parameter \\#1 \\$request of method Mage_Tax_Model_Resource_Calculation\\:\\:getCalculationProcess\\(\\) expects Varien_Object, null given\\.$#" count: 1 path: app/code/core/Mage/Tax/Model/Calculation.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store\\|null given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Calculation.php - - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateOriginRequest\\(\\) expects Mage_Core_Model_Store\\|null, int\\|null given\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Model/Calculation.php - - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store\\|null given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Property Mage_Tax_Model_Calculation\\:\\:\\$_customer \\(Mage_Customer_Model_Customer\\) does not accept false\\.$#" count: 1 @@ -10250,11 +9915,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Resource/Report/Tax/Createdat.php - - - message: "#^Return type \\(void\\) of method Mage_Tax_Model_Sales_Total_Quote_Discount\\:\\:collect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Abstract\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:collect\\(\\)$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php - - message: "#^Return type \\(array\\) of method Mage_Tax_Model_Sales_Total_Quote_Nominal_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:fetch\\(\\)$#" count: 1 @@ -10265,51 +9925,21 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Model_Config\\:\\:discountTax\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Parameter \\#2 \\$rate of method Mage_Tax_Model_Sales_Total_Quote_Shipping\\:\\:_round\\(\\) expects string, float given\\.$#" count: 4 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php - - message: "#^Call to function is_null\\(\\) with Varien_Object will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Model_Config\\:\\:discountTax\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 4 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Parameter \\#2 \\$rate of method Mage_Tax_Model_Sales_Total_Quote_Subtotal\\:\\:_deltaRound\\(\\) expects string, float given\\.$#" count: 4 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -10320,16 +9950,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Parameter \\#4 \\$value of method Mage_Weee_Helper_Data\\:\\:setWeeeTaxesAppliedProperty\\(\\) expects string, \\(array\\|float\\|int\\) given\\.$#" count: 4 @@ -10845,11 +10465,6 @@ parameters: count: 1 path: app/code/core/Mage/Weee/Model/Tax.php - - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store\\|false given\\.$#" - count: 1 - path: app/code/core/Mage/Weee/Model/Tax.php - - message: "#^Parameter \\#2 \\$shipping of method Mage_Weee_Model_Tax\\:\\:getProductWeeeAttributes\\(\\) expects Mage_Sales_Model_Quote_Address\\|null, Mage_Customer_Model_Address_Abstract\\|null given\\.$#" count: 1 @@ -10860,11 +10475,6 @@ parameters: count: 1 path: app/code/core/Mage/Weee/Model/Tax.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store\\|false given\\.$#" - count: 1 - path: app/code/core/Mage/Weee/Model/Tax.php - - message: "#^Parameter \\#1 \\$item of method Mage_Weee_Helper_Data\\:\\:getApplied\\(\\) expects Mage_Sales_Model_Quote_Item_Abstract, Mage_Sales_Model_Order_Creditmemo_Item given\\.$#" count: 1 @@ -10890,11 +10500,6 @@ parameters: count: 1 path: app/code/core/Mage/Weee/Model/Total/Quote/Weee.php - - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" - count: 2 - path: app/code/core/Mage/Weee/Model/Total/Quote/Weee.php - - message: "#^Parameter \\#4 \\$website of method Mage_Weee_Helper_Data\\:\\:getProductWeeeAttributes\\(\\) expects Mage_Core_Model_Website\\|null, int\\|string\\|null given\\.$#" count: 2 @@ -10905,11 +10510,6 @@ parameters: count: 2 path: app/code/core/Mage/Weee/Model/Total/Quote/Weee.php - - - message: "#^Return type \\(void\\) of method Mage_Weee_Model_Total_Quote_Weee\\:\\:_recalculateParent\\(\\) should be compatible with return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:_recalculateParent\\(\\)$#" - count: 1 - path: app/code/core/Mage/Weee/Model/Total/Quote/Weee.php - - message: "#^Method Mage_Widget_Block_Adminhtml_Widget_Chooser\\:\\:getConfig\\(\\) should return Varien_Object but returns mixed\\.$#" count: 2 @@ -10960,21 +10560,11 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Block/Customer/Sharing.php - - - message: "#^Return type \\(void\\) of method Mage_Wishlist_Block_Customer_Sharing\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Wishlist/Block/Customer/Sharing.php - - message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Resource_Item_Collection will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Wishlist/Block/Customer/Sidebar.php - - - message: "#^Return type \\(void\\) of method Mage_Wishlist_Block_Customer_Wishlist\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Catalog_Block_Product_Abstract\\)\\) of method Mage_Catalog_Block_Product_Abstract\\:\\:_prepareLayout\\(\\)$#" - count: 1 - path: app/code/core/Mage/Wishlist/Block/Customer/Wishlist.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -11080,11 +10670,6 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - - message: "#^Return type \\(void\\) of method Mage_Wishlist_IndexController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" - count: 1 - path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - message: "#^Parameter \\#2 \\$value of function ini_set expects string, int given\\.$#" count: 1