Idea for better handling errors with Ignition

[empiricompany]

Thanks @fballiano for your smart PR about ignition support, i think it has great potential.

I was looking into how to manage the configuration file; for better integration through an external extension, we could add these two observers:

This way, we can implement it better, taking inspiration from the Drupal module:
https://git.drupalcode.org/project/ignition/tree/1.0.x

what do you think about?

PS: I'm quite busy at work right now, so I wouldn't be able to work on it immediately, but I wanted to do some brainstorming in the meantime

[empiricompany]

It would be amazing to also leverage the integration with Flare and with OpenAI!
Also, for "branding/marketing", being listed among the supported extensions with OpenMage would give us a nice boost.

[fballiano]

I thought about it but I wanted to implement that minimum modification to the core that was necessary and couldn't be (as far as I know) added via a module.
maybe some more feature can be added without having to modify the core? maybe with the 2 events it would be possible to have an ignition module instead of the patch to the core?

[empiricompany]

Yes, I was thinking exactly that. By adding those two events, the module can observe into and manage everything better.
But as I mentioned, for now, I would leave your patch because I don't have time to implement it.

[luigifab]

This PR for ignition looks like #3679 🤫

[fballiano]

yep, ignition supports linking to the IDE, it works fine for me

[fballiano]

I wanted to use an event to trigger ignition but it wasn't available so I added it to the core :-)
But thinking about it, if we add the dispatchevent and trigger Ignition from that event, we're adding a few calls to the stack, which will make the output of ignition a bit harder to read since you will have to go back 2-3 steps in the call stack to see the code that actually broke.
It's worth testing tho.

[empiricompany]

True, I hadn't figured that out. It would also show in the stack, you mean this, right?

[empiricompany]

@fballiano i have started here:
https://github.com/empiricompany/openmage_ignition

seems ok, to handle it we have to add 2/3 new events:
Mage.php
mage_print_exception_before
mage_print_exception_after (not used by the extension)
App.php
core_app_init_before