Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated strftime and gmstrftime PHP functions #2030

Closed
elidrissidev opened this issue Mar 2, 2022 · 3 comments · Fixed by #2951
Closed

Replace deprecated strftime and gmstrftime PHP functions #2030

elidrissidev opened this issue Mar 2, 2022 · 3 comments · Fixed by #2951
Labels
good first issue easy to solve issues PHP 8.1 Related to PHP 8.1

Comments

@elidrissidev
Copy link
Member

The PHP functions strftime and gmstrftime were deprecated starting from PHP 8.1 and will be removed in the next major version, we should consider replacing them with alternatives without changing the behavior.

Ref: https://php.watch/versions/8.1/strftime-gmstrftime-deprecated
@kiatng
Copy link
Contributor

kiatng commented Mar 3, 2022 •
edited
Loading

Duplicate of issue #1812 .

[edit] Please reopen if this should be fixed first ahead of issue #1812.

@kiatng kiatng closed this as completed Mar 3, 2022
@elidrissidev
Copy link
Member Author

@kiatng Sorry, I didn't notice that PR. Although I do prefer small incremental fixes that are easier to review and merge.

@kiatng
Copy link
Contributor

kiatng commented Sep 27, 2022

Issue #1812 was closed without resolution.

@kiatng kiatng reopened this Sep 27, 2022
@elidrissidev elidrissidev added hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) PHP 8 Related to PHP8 labels Sep 28, 2022
@elidrissidev elidrissidev added good first issue easy to solve issues and removed hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) labels Nov 26, 2022
@sreichel sreichel added PHP 8.1 Related to PHP 8.1 and removed PHP 8 Related to PHP8 labels Jan 6, 2023
This was referenced Jan 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue easy to solve issues PHP 8.1 Related to PHP 8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated gmstrftime with gmdate elidrissidev/magento-lts
3 participants
@kiatng @sreichel @elidrissidev