From f5378b56a390504358dfc85418569e142a4134f1 Mon Sep 17 00:00:00 2001 From: Fabrizio Balliano Date: Fri, 21 Apr 2023 10:16:47 +0100 Subject: [PATCH 1/2] Fixed deprecation warning on Mage_Catalog_Helper_Image --- app/code/core/Mage/Catalog/Helper/Image.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/code/core/Mage/Catalog/Helper/Image.php b/app/code/core/Mage/Catalog/Helper/Image.php index fdc415257e2..16a41808acc 100644 --- a/app/code/core/Mage/Catalog/Helper/Image.php +++ b/app/code/core/Mage/Catalog/Helper/Image.php @@ -564,13 +564,18 @@ protected function getImageFile() */ protected function parseSize($string) { + if ($string === null) { + return false; + } + $size = explode('x', strtolower($string)); - if (count($size) === 2) { + if (is_array($size) && count($size) === 2) { return [ 'width' => ($size[0] > 0) ? $size[0] : null, 'heigth' => ($size[1] > 0) ? $size[1] : null, ]; } + return false; } From 0577c095eb8ba24ca7db59211aab248d19eb21f4 Mon Sep 17 00:00:00 2001 From: Fabrizio Balliano Date: Fri, 28 Apr 2023 09:54:36 +0100 Subject: [PATCH 2/2] explode always returns an array --- app/code/core/Mage/Catalog/Helper/Image.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/core/Mage/Catalog/Helper/Image.php b/app/code/core/Mage/Catalog/Helper/Image.php index 16a41808acc..abe8cbdb96d 100644 --- a/app/code/core/Mage/Catalog/Helper/Image.php +++ b/app/code/core/Mage/Catalog/Helper/Image.php @@ -569,7 +569,7 @@ protected function parseSize($string) } $size = explode('x', strtolower($string)); - if (is_array($size) && count($size) === 2) { + if (count($size) === 2) { return [ 'width' => ($size[0] > 0) ? $size[0] : null, 'heigth' => ($size[1] > 0) ? $size[1] : null,