Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI pipeline and version release system in syft-proto with Github actions #36

Closed
cereallarceny opened this issue Feb 3, 2020 · 5 comments
Assignees
Labels
Type: Epic 🤙 Describes a large amount of functionality that will likely be broken down into smaller issues

Comments

@cereallarceny
Copy link
Member

cereallarceny commented Feb 3, 2020

In theory, the syft-proto project will drive a lot of class creation in PySyft when those classes will inevitably be used by a worker library (syft.js, KotlinSyft, or SwiftSyft). In order to avoid issues of subtleties existing between various versions of OpenMined projects, it may be best to centralize all continuous integration, end-to-end testing, and version release management into one place. This isn't an issue that necessitates a code change (but if it does, it should be fairly minimal), but more a designation that we will need to hook up all the projects together into a CI pipeline that is run on an interval and runs our end-to-end tests (#37). This ensures that all versions of the workers are compatible with PySyft and PyGrid. This will allows to almost catch issues before our users do.

@cereallarceny cereallarceny added the Type: Epic 🤙 Describes a large amount of functionality that will likely be broken down into smaller issues label Feb 3, 2020
@karlhigley
Copy link
Contributor

What's left to do to in order to close this issue? I think we've got Python, Java, and Swift packages being built from the automated Actions, yeah?

@cereallarceny
Copy link
Member Author

I was thinking we would have the ability to test each library that claims syft-proto as a dependency with the latest version of the library every time it’s updated. Basically ensuring that each of our projects continues to work as expected when a new syft-proto version is released.

@karlhigley
Copy link
Contributor

Ah, okay. What we have at the moment is breaking change detection on the schemas, which will tell us when Protobuf changes will definitely break the downstream projects, but doesn't tell us that the downstream projects still work as expected for (assumed) non-breaking changes.

@cereallarceny
Copy link
Member Author

Ahh that’s good enough for me then. If you think we’re good here, feel free to close. It seems like the scope of this issue has changed.

@cereallarceny
Copy link
Member Author

I don't believe this issue is currently relevant and will be handled by the new release management team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Epic 🤙 Describes a large amount of functionality that will likely be broken down into smaller issues
Projects
None yet
Development

No branches or pull requests

3 participants