Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Original song author doesn't show up if there is no song author #214

Closed
CubixL opened this issue Dec 10, 2020 · 1 comment
Closed

Original song author doesn't show up if there is no song author #214

CubixL opened this issue Dec 10, 2020 · 1 comment
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Milestone
v3.x

Comments

@CubixL
Copy link

CubixL commented Dec 10, 2020

Describe the bug
In the song properties, if you leave the song author blank but type in the original song author, that author doesn't show up in the intro message when loading up the song

To Reproduce

  1. Create/open a new song
  2. Go to "Song Properties" in Settings
  3. Write stuff in the Original song author field but leave Song author blank
  4. Click "Song info" in Settings or load up the song again
  5. The "Originally created by [person]" text doesn't show up

Expected behavior
The text to actually display

Screenshots
song_properties
song_info
@Bentroen Bentroen added the C: Bug Something isn't working label Dec 10, 2020
@Bentroen Bentroen added this to the v3.8.1 milestone Dec 10, 2020
@Bentroen Bentroen modified the milestones: v3.8.1, v3.8.2 Jan 3, 2021
@chenxi050402 chenxi050402 mentioned this issue May 23, 2021
Merged
@chenxi050402 chenxi050402 added the S: Resolved in next release This bugfix or suggestion has been applied to the code label Aug 18, 2021
@Bentroen
Copy link
Member

Fixed in c36a984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Projects
None yet
Milestone
v3.x
Development

No branches or pull requests
3 participants
@Bentroen @CubixL @chenxi050402