Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing notes at high tick speeds #309

Closed
Glimmlit opened this issue Feb 9, 2022 · 4 comments
Closed

missing notes at high tick speeds #309

Glimmlit opened this issue Feb 9, 2022 · 4 comments
Labels
C: Bug Something isn't working S: Won't Fix This will not be worked on

Comments

@Glimmlit
Copy link

Glimmlit commented Feb 9, 2022

Note Block Studio starts missing notes when many notes are played at a high tick speed.
thingy

could record a video of my project and link it so just ask if thats needed.

@Bentroen
Copy link
Member

Hi! We are aware of this issue -- the program only plays the notes that are directly under the marker, but at that tick speed it moves so fast that some notes are completely skipped.

We even took actions to remedy it before -- more specifically, we store the last tick that was played and play all ticks from that point up until the current marker position (see #101).

The only problem with this approach is, there's no way to differentiate this situation from the user dragging to resize the window, which causes the program to freeze completely until you release the mouse. As such, if you dragged the window for a few seconds and then let go of it, the noise caused by all the piled up notes could be loud enough to seriously damage your ears.

Because of that, we deliberately limited the "piled up" notes to only the last three ticks behind the marker. I'm not sure there's a way to improve it further, but I'll leave this issue open for now as it's technically still a problem (especially since v3.9.0 where the tempo can go up to 60 t/s).

@Bentroen Bentroen added the C: Bug Something isn't working label Feb 10, 2022
@mckuhei
Copy link

mckuhei commented Feb 20, 2022

try increasing the frame rate

@Glimmlit
Copy link
Author

Glimmlit commented Feb 24, 2022 via email

@Bentroen Bentroen added the S: Won't Fix This will not be worked on label Jun 2, 2023
@Bentroen
Copy link
Member

Bentroen commented Jun 2, 2023

I believe the measures we have implemented to alleviate this (see comment above) are already enough to remedy the issue. Playing multiple piled-up notes could be really dangerous in case the program freezes for an extended amount of time.

@Bentroen Bentroen closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Bug Something isn't working S: Won't Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants