Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginormous image sideloads when using "enlargement" #21

Closed
tamw-wnet opened this issue Nov 18, 2022 · 2 comments
Closed

ginormous image sideloads when using "enlargement" #21

tamw-wnet opened this issue Nov 18, 2022 · 2 comments

Comments

@tamw-wnet
Copy link
Member

I've been noticing stories like this one API ID 1134823910
https://www.npr.org/2022/11/17/1134823910/nador-morocco-spain-migration-immigrants
where the primary image has an 'enlargement' that is 10MB+, and that's what the plugin sideloads. On a slower server, this will cause an error or timeout while trying to download and manipulate the image.

Should we automatically add an 's=6' parameter to any of these enlargments so we get an image that is still quite large but not egregious? I can do so @jwcounts just looking for your thoughts.

@jwcounts
Copy link

I would say to look for the enlargement image crop and check the width first. If it's over 1500-2000px, then add the 's=6'.

@tamw-wnet
Copy link
Member Author

#22 resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants