Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test all the functions of OSTPrime. #417

Closed
deepesh-kn opened this issue Oct 26, 2018 · 1 comment · Fixed by #533
Closed

Unit test all the functions of OSTPrime. #417

deepesh-kn opened this issue Oct 26, 2018 · 1 comment · Fixed by #533
Assignees

Comments

@deepesh-kn
Copy link
Contributor

deepesh-kn commented Oct 26, 2018

This story cover the following.

  • Add unit tests for all the functions. (Please refer Utilitytoken test in openst-contract)
  • Test of wrap and unwrap is already part of another ticket.
  • Add Error message for requires if it is missing.
@deepesh-kn deepesh-kn changed the title Gateway: Unit test for OSTPrime. Unit test all the functions of OSTPrime. Nov 20, 2018
@deepesh-kn deepesh-kn self-assigned this Dec 7, 2018
@schemar
Copy link
Contributor

schemar commented Dec 7, 2018

Please make sure that you fully test claim and redeem (wrap and unwrap).

Specifically:

// Line 138 should probably not be `transfer`, but rather:
transferFrom(msg.sender, address(this), _amount);

// Line 163 should probably not be `transferFrom`, but rather:
transfer(msg.sender, _amount);

Looks like a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants