Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write extensive tests for MerklePatriciaProof library #653

Closed
0xsarvesh opened this issue Feb 20, 2019 · 3 comments
Closed

Write extensive tests for MerklePatriciaProof library #653

0xsarvesh opened this issue Feb 20, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@0xsarvesh
Copy link
Contributor

0xsarvesh commented Feb 20, 2019

Step 0 should be implementing a way to generate random positive and negative proofs. With good permutations of node types and branch depths. That can be used to generate MPP proofs for unit tests.
Input to the generator should be a given "form" of path. The input should define the order and number of branch and extension nodes. The input should also define whether there is a leaf node. It could correctly end on a branch node. Or it could be incorrectly constructed.

Step 1 should be generating good data sets for unit tests to cover many (edge) cases.

Step 2: add the unit tests.

At a later stage, we could use the generator code to implement something that continuously runs and tests MPP. We may also run fuzzy test suites (echidna) to find errors and/or interesting unit test cases.

Refer #652

@schemar
Copy link
Contributor

schemar commented Feb 20, 2019

Tests should contain positive and negative test cases.
If it is possible to generate correct and incorrect proofs, then that would simplify this a lot.

@schemar
Copy link
Contributor

schemar commented Apr 8, 2019

Must be split into smaller issues.

@benjaminbollen
Copy link
Contributor

@sarvesh, could you give this a go to write the separate tickets?

@0xsarvesh 0xsarvesh added the Epic label Apr 16, 2019
@schemar schemar added this to the Sprint 0 milestone May 2, 2019
@deepesh-kn deepesh-kn modified the milestones: Sprint 0, sprint 1 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants