Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TokenHolder.redeem signature after _facilitator argument is removed from CoGateway.redeem() in mosaic-contracts. #81

Closed
abhayks1 opened this issue Nov 2, 2018 · 2 comments

Comments

@abhayks1
Copy link
Contributor

abhayks1 commented Nov 2, 2018

Current Implementation
https://github.com/OpenSTFoundation/mosaic-contracts/blob/develop/contracts/gateway/EIP20CoGateway.sol#L590

As per discussion with Gateway team, facilitator will be removed from redeem function.
Accordingly CoGatewayRedeemInterface.sol and TokenHolder.redeem function signature needs to be updated.

@abhayks1 abhayks1 changed the title Update redeem signature after _facilitator argument is removed from CoGateway.redeem() in mosaic-contracts. Update TokenHolder.redeem signature after _facilitator argument is removed from CoGateway.redeem() in mosaic-contracts. Nov 2, 2018
@abhayks1
Copy link
Contributor Author

abhayks1 commented Dec 5, 2018

It should be taken after below PR is merged:
OpenST/mosaic-contracts#517

Tracking Issue: OpenST/mosaic-contracts#475

@pgev
Copy link
Collaborator

pgev commented Dec 19, 2018

Closing the issue, as redeem functionality is going to be updated in #124.

@pgev pgev closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants