From 4921ece24c6146d956a20de4393d4d972dccd1fe Mon Sep 17 00:00:00 2001 From: Kevin FS <10007010+kevinfs510@users.noreply.github.com> Date: Mon, 2 Dec 2019 12:17:31 +0800 Subject: [PATCH 1/6] Update OstCustomLoader.md --- Samples/customloader/OstCustomLoader.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Samples/customloader/OstCustomLoader.md b/Samples/customloader/OstCustomLoader.md index 8cdb0197..5bf6e40a 100644 --- a/Samples/customloader/OstCustomLoader.md +++ b/Samples/customloader/OstCustomLoader.md @@ -1,4 +1,4 @@ -# Custom Loader Useage +# Custom Loader Usage ## Setup 1. Application project should have `ost-wallet-sdk-android` dependency. From f568c3b85c601e1212664af50d5c9bba108e49ba Mon Sep 17 00:00:00 2001 From: sachinchauhan Date: Fri, 13 Dec 2019 13:38:03 +0530 Subject: [PATCH 2/6] Propagating Ost Error in createRecoveryKey --- .../com/ost/walletsdk/ecKeyInteracts/InternalKeyManager.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ostsdk/src/main/java/com/ost/walletsdk/ecKeyInteracts/InternalKeyManager.java b/ostsdk/src/main/java/com/ost/walletsdk/ecKeyInteracts/InternalKeyManager.java index 8fb96724..fecbe8c1 100644 --- a/ostsdk/src/main/java/com/ost/walletsdk/ecKeyInteracts/InternalKeyManager.java +++ b/ostsdk/src/main/java/com/ost/walletsdk/ecKeyInteracts/InternalKeyManager.java @@ -733,9 +733,11 @@ String signDataWithRecoveryKey(String hexStringToSign, UserPassphrase passphrase // Sign the data. Sign.SignatureData signatureData = Sign.signMessage(Numeric.hexStringToByteArray(hexStringToSign), ecKeyPair, false); return Numeric.toHexString(signatureData.getR()) + Numeric.cleanHexPrefix(Numeric.toHexString(signatureData.getS())) + String.format("%02x", (signatureData.getV())); + } catch (OstError ostError) { + throw ostError; } catch (Throwable th) { //Supress it. - return null; + throw new OstError("c_ikm_sdwrk_1", ErrorCode.FAILED_TO_SIGN_DATA); } finally { if ( null == ecKeyPair ) { clearBytes(salt); From b4f8cbc1a3ab2c90b1b50b0155a8f5b4ae1b7c3c Mon Sep 17 00:00:00 2001 From: sachinchauhan Date: Fri, 13 Dec 2019 13:51:29 +0530 Subject: [PATCH 3/6] version bump up from 48 to 49 --- ostsdk/gradle.properties | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ostsdk/gradle.properties b/ostsdk/gradle.properties index 3607bfc1..78d1a1a6 100644 --- a/ostsdk/gradle.properties +++ b/ostsdk/gradle.properties @@ -22,9 +22,9 @@ # org.gradle.parallel=true #Increase version when publishing. -VERSION_NAME=2.3.6 +VERSION_NAME=2.3.7 #Increase version code when publishing. -VERSION_CODE=48 +VERSION_CODE=49 #Everything else. GROUP=com.ost From 26b39efc7a688e65f85f518b087c879394e6b2b0 Mon Sep 17 00:00:00 2001 From: sachinchauhan Date: Fri, 13 Dec 2019 14:02:00 +0530 Subject: [PATCH 4/6] Readme and Change log update --- CHANGELOG.md | 4 ++++ README.md | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index affb9f3b..f37b1d36 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # OST Wallet SDK Changelog +## Version 2.3.7 +### Bug Fix: +* In recover device flow added handling of OutOfMemory error. + ## Version 2.3.6 ### Changes: * Added support for custom loader for OstWalletSDK UI workflows. diff --git a/README.md b/README.md index 711144b0..d55cfefc 100644 --- a/README.md +++ b/README.md @@ -108,7 +108,7 @@ compileOptions { ``` dependencies { - implementation 'com.ost:ost-wallet-sdk-android:2.3.6' + implementation 'com.ost:ost-wallet-sdk-android:2.3.7' ... ... ... From c735259826bcd0140477919a38e43a455343127c Mon Sep 17 00:00:00 2001 From: sachinchauhan Date: Fri, 13 Dec 2019 14:04:50 +0530 Subject: [PATCH 5/6] Change log update --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f37b1d36..eeb69ca5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## Version 2.3.7 ### Bug Fix: -* In recover device flow added handling of OutOfMemory error. +* In recover device flow added propagation of OstError. ## Version 2.3.6 ### Changes: From ee1552ffcff28fbb99661fa8c06daa7b32d44f53 Mon Sep 17 00:00:00 2001 From: sachinchauhan Date: Fri, 13 Dec 2019 15:01:27 +0530 Subject: [PATCH 6/6] Change log update --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index eeb69ca5..631f6fd8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## Version 2.3.7 ### Bug Fix: -* In recover device flow added propagation of OstError. +* Inaccurate error is thrown when application runs out of memory during recover device workflow. ## Version 2.3.6 ### Changes: