Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only organization should anchor state roots #560

Merged
merged 9 commits into from
Dec 21, 2018
Merged

Only organization should anchor state roots #560

merged 9 commits into from
Dec 21, 2018

Conversation

gulshanvasnani
Copy link
Contributor

@gulshanvasnani gulshanvasnani commented Dec 19, 2018 •
edited
Loading

Note :- Do not merge before #549
PR contains following :-

  1. Changed the modifier of method commitStateRoot to onlyOrganization.
  2. Added unit test case where not admin address is passed.
  3. Modified unit test cases.

Fixes #556

@gulshanvasnani gulshanvasnani self-assigned this Dec 19, 2018
@gulshanvasnani gulshanvasnani requested review from deepesh-kn, schemar and 0xsarvesh and removed request for schemar December 19, 2018 16:18
schemar
schemar suggested changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🍪

Please remove extra spaces and redundant test. Otherwise good 😸

test/gateway/safe_core/commit_state_root.js Outdated Show resolved Hide resolved
test/gateway/safe_core/commit_state_root.js Outdated Show resolved Hide resolved
schemar
schemar approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

schemar
schemar approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one
image

0xsarvesh
0xsarvesh approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@0xsarvesh 0xsarvesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🥇🚜

@schemar Sorry, more merge conflicts for Organization PR 😞

@0xsarvesh 0xsarvesh merged commit 37870e6 into OpenST:develop Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xsarvesh 0xsarvesh 0xsarvesh approved these changes

@schemar schemar schemar approved these changes

@deepesh-kn deepesh-kn Awaiting requested review from deepesh-kn

Assignees

@gulshanvasnani gulshanvasnani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gulshanvasnani @schemar @0xsarvesh @benjaminbollen