Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeem and unstake integration test #638

Merged
merged 10 commits into from
Feb 5, 2019
Merged

Redeem and unstake integration test #638

merged 10 commits into from
Feb 5, 2019

Conversation

0xsarvesh
Copy link
Contributor

@0xsarvesh 0xsarvesh commented Feb 4, 2019 •
edited
Loading

Fixes #611
Redeem and un-stake integration tests.

@0xsarvesh 0xsarvesh self-assigned this Feb 4, 2019
schemar
schemar suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉
Some typos. Please also re-check yourself.

test_integration/03_redeem_and_unstake/01_redeem_and_unstake.js Show resolved Hide resolved
test_integration/03_redeem_and_unstake/01_redeem_and_unstake.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/01_redeem_and_unstake.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/01_redeem_and_unstake.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/01_redeem_and_unstake.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
schemar
schemar approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Still some smaller typos.

test_integration/03_redeem_and_unstake/01_redeem_and_unstake.js Show resolved Hide resolved
test_integration/03_redeem_and_unstake/01_redeem_and_unstake.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/confirm_redeem_intent_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/confirm_redeem_intent_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
deepesh-kn
deepesh-kn approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me ✔️
I did a quick scan, I have just minor documentation issues.

test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_unstake_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_redeem_assertion.js Outdated Show resolved Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_redeem_assertion.js Outdated Show resolved Hide resolved
hobofan
hobofan approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@hobofan hobofan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛵️

@schemar schemar merged commit 47082b9 into OpenST:develop Feb 5, 2019
@abhayks1 abhayks1 mentioned this pull request May 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepesh-kn deepesh-kn deepesh-kn approved these changes

@schemar schemar schemar approved these changes

@hobofan hobofan hobofan approved these changes

Assignees

@0xsarvesh 0xsarvesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xsarvesh @hobofan @schemar @deepesh-kn