Fix Resvg image format #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM from what I can tell 👍 |
|
Retrying build, now that ppa.launchpad.net is hopefully up from its nap. |
|
This has been confirmed effective in fixing our AppImage color inversion bug, so merging to develop... (it's already in the release PR) |
ferdnyc
commented
Jan 12, 2020
Comment on lines
+106
to
+111
| message(STATUS " SHARED IMPORTED target with IMPORTED_NO_SONAME") | ||
| endif() | ||
|
|
||
| message(STATUS " INCLUDE_DIRECTORIES: ${RESVG_INCLUDE_DIRS}") | ||
| message(STATUS " COMPILE_DEFINITIONS: ${RESVG_DEFINITIONS}") | ||
| message(STATUS " IMPORTED_LOCATION: ${RESVG_LIBRARIES}") |
There was a problem hiding this comment.
GAAAH. I meant to take those out before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resvg should be rendering to
QImage::Format_ARGB32_Premultiplied, according to @RazrFalcon.Also, tightened up the code a bit. Works fine on my system, but the AppImage will be the ultimate test.