Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Limit scope of AUTOMOC #449

Merged
merged 1 commit into from
Feb 26, 2020
Merged

CMake: Limit scope of AUTOMOC #449

merged 1 commit into from
Feb 26, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Feb 25, 2020

  • Only set AUTOMOC property on library target
  • Only use the Qt headers in target_sources()
  • Make Qt headers PRIVATE sources, to avoid migration to other targets

@ferdnyc
CMake: Limit scope of AUTOMOC
c98ee59 
- Only set AUTOMOC property on library target
- Only use the Qt headers in target_sources()
- Make Qt headers PRIVATE sources, to avoid migration to other targets
@ferdnyc ferdnyc added the build Issues related to compiling or installing libopenshot and its dependencies label Feb 25, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 25, 2020

This change prevents a <target>_autogen directory from being created for every target in the build (a consequence of global CMAKE_AUTOMOC), and prevents the Qt headers from being MOC'd separately for each target (a consequence of the PUBLIC headers).

@ferdnyc ferdnyc merged commit 689f1e1 into develop Feb 26, 2020
@ferdnyc ferdnyc deleted the fix-automoc branch February 26, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues related to compiling or installing libopenshot and its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferdnyc