Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed JSON communication for detected objects #674

Merged
merged 4 commits into from
May 19, 2021

Conversation

BrennoCaldato
Copy link
Collaborator

Changed JSON communication for detected objects

  • The OBjectDetection and Tracker effects have a key "objects" in the Json that contains a dictionary of TrackedObjectBBox indexed by the object ID
  • self.data now keep track of all changes in detected objects

Example of the JSON for ObjectDetection:

{ // effect parameters
        "id": 7QCETIYKEJ
        "selected_object_index": "2"
        "confidence_threshold": "0.5"
        "class_filter": "truck"
        "objects":{
                //these are the detected objects dicts
                "9FDETJYKEJ":{
                        "box_id" : "9FDETJYKEJ"
                        "x1": "50"
                        "y1": "50"
                        "x2": "100"
                        "y2": "100"
                        "delta_x": {...}
                        ...
                }
                "56BR38F17U":{
                        "box_id" : "56BR38F17U"
                        "x1": "50"
                        "y1": "50"
                        "x2": "100"
                        "y2": "100"
                        "delta_x": {...}
                        ...
                }
        }
}

@BrennoCaldato BrennoCaldato changed the title Fix saving Changed JSON communication for detected objects May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #674 (e2b51da) into effect-parenting (a00bbb7) will increase coverage by 0.65%.
The diff coverage is 22.48%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           effect-parenting     #674      +/-   ##
====================================================
+ Coverage             52.42%   53.08%   +0.65%     
====================================================
  Files                   151      132      -19     
  Lines                 12346    11093    -1253     
====================================================
- Hits                   6473     5889     -584     
+ Misses                 5873     5204     -669     
Impacted Files Coverage Δ
src/Clip.h 56.25% <0.00%> (-18.75%) ⬇️
src/Color.cpp 87.93% <0.00%> (-12.07%) ⬇️
src/Color.h 100.00% <ø> (ø)
src/EffectBase.h 50.00% <0.00%> (-50.00%) ⬇️
src/KeyFrame.h 100.00% <ø> (ø)
src/Timeline.h 63.63% <ø> (ø)
src/TimelineBase.cpp 60.00% <0.00%> (-40.00%) ⬇️
src/TrackedObjectBase.cpp 0.00% <0.00%> (ø)
src/TrackedObjectBase.h 0.00% <0.00%> (ø)
src/effects/Bars.cpp 0.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9d196...e2b51da. Read the comment docs.

@BrennoCaldato BrennoCaldato merged commit 461a030 into effect-parenting May 19, 2021
@BrennoCaldato BrennoCaldato deleted the fix-saving branch May 19, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant