Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Make ImageWriter tests optional #685

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jun 6, 2021

(I KNEW I'd merged this already, but apparently the change got lost in a subsequent merge of a different branch. Re-applying.)

Just like the OpenCV tests require OpenCV, the ImageWriter tests
require that ImageMagick be enabled in the build. If it isn't,
skip those tests.

Just like the OpenCV tests require OpenCV, the ImageWriter tests
require that ImageMagick be enabled in the build. If it isn't,
skip those tests.
@ferdnyc ferdnyc added build Issues related to compiling or installing libopenshot and its dependencies tests Changes related to the unit tests and/or code coverage labels Jun 6, 2021
@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #685 (81b61e9) into develop (8a81452) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #685   +/-   ##
========================================
  Coverage    50.41%   50.41%           
========================================
  Files          155      155           
  Lines        13315    13315           
========================================
  Hits          6713     6713           
  Misses        6602     6602           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a81452...81b61e9. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 6, 2021

Screenshot from 2021-06-06 10-01-13

Well... why not?? I DO want to request changes!

tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@ferdnyc ferdnyc merged commit d9ea98e into OpenShot:develop Jun 7, 2021
@ferdnyc ferdnyc deleted the optional-imagereader-tests branch June 7, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to compiling or installing libopenshot and its dependencies tests Changes related to the unit tests and/or code coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant