SCALE_NONE was incorrectly sizing SVG, Image, and Video files. #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpenShot changes the preview window size during editing, the SCALE_NONE clips should always be scaled to the ratio: preview / timeline... so they stay relative sized to the timeline size. For example, if an SVG is 500px wide, and the project is 1000px wide... the SVG in SCALE_NONE mode should always be 50% with width of the video, regardless of how small you make the preview window.
|
Looks like I have some unit test failures... oops |
Codecov Report
@@ Coverage Diff @@
## develop #713 +/- ##
===========================================
+ Coverage 46.24% 46.36% +0.11%
===========================================
Files 182 182
Lines 16701 16760 +59
===========================================
+ Hits 7724 7770 +46
- Misses 8977 8990 +13
Continue to review full report at Codecov.
|
JacksonRG
reviewed
Aug 12, 2021
JacksonRG
reviewed
Aug 12, 2021
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenShot changes the preview window size during editing, the SCALE_NONE clips should always be scaled to the ratio:
preview width / timeline width... so they stay relative sized to the timeline size.For example, if an SVG is 500px wide, and the project is 1000px wide... the SVG in SCALE_NONE mode should always be 50% with width of the video, regardless of how small you make the preview window.