Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing crash related to Undo #864

Merged
merged 7 commits into from
Oct 29, 2022
Merged

Fixing crash related to Undo #864

merged 7 commits into from
Oct 29, 2022

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Oct 27, 2022

Related to OpenShot/openshot-qt#4965

  • New unit tests to verify Readers and FrameMappers are correctly cleaned up
  • Some refactoring to ensure no double free on Reader cleanup

@jonoomph
Copy link
Member Author

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #864 (1547fb1) into develop (1186c24) will increase coverage by 0.60%.
The diff coverage is 95.18%.

❗ Current head 1547fb1 differs from pull request most recent head 7a733c0. Consider uploading reports for the commit 7a733c0 to get more accurate results

@@             Coverage Diff             @@
##           develop     #864      +/-   ##
===========================================
+ Coverage    50.48%   51.08%   +0.60%     
===========================================
  Files          184      184              
  Lines        15994    16063      +69     
===========================================
+ Hits          8074     8206     +132     
+ Misses        7920     7857      -63     
Impacted Files Coverage Δ
src/Timeline.cpp 55.23% <63.63%> (+5.78%) ⬆️
src/Clip.cpp 59.09% <100.00%> (+2.53%) ⬆️
tests/Clip.cpp 100.00% <100.00%> (ø)
tests/Timeline.cpp 100.00% <100.00%> (ø)
src/FrameMapper.cpp 94.69% <0.00%> (+0.66%) ⬆️
src/Timeline.h 82.60% <0.00%> (+4.34%) ⬆️
src/DummyReader.h 100.00% <0.00%> (+33.33%) ⬆️
src/QtImageReader.h 100.00% <0.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- Bug fix for clip, to delete a new Reader, regardless of how it was set (correctly track allocated readers, and ignore FrameMappers pointed to existing allocated reader)
- Bug fix for timeline to correctly wrap Reader with FrameMapper
…y_json_to_timeline()` to not clear all cache when setting the timeline's "duration" - an optimization for performance
@jonoomph jonoomph merged commit cd514a1 into develop Oct 29, 2022
@jonoomph jonoomph deleted the fix-undo-redo branch October 29, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant