Fix a huge regression which invokes the avcodec_open() twice #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or every call to FFmpegReader::Open(), leaving many threads running and never joined/closed. Also, adding some additional error message when attempting to call avcodec_open().
jonoomph
commented
Nov 27, 2022
| @@ -569,13 +573,13 @@ void FFmpegReader::Open() { | |||
| CheckFPS(); | |||
| } | |||
|
|
|||
| // Mark as "open" | |||
| is_open = true; | |||
|
|
|||
| // Seek back to beginning of file (if not already seeking) | |||
| if (!is_seeking) { | |||
| Seek(1); | |||
There was a problem hiding this comment.
Since the Seek() method can actually Close() and re Open() this reader, it's important we mark the reader as is_open = True before doing this... so our Close method can actually clean up the open reader.
Codecov Report
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 51.86% 51.86% -0.01%
===========================================
Files 187 187
Lines 16335 16338 +3
===========================================
+ Hits 8472 8473 +1
- Misses 7863 7865 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a huge regression which invokes the
avcodec_open()twice for every call toFFmpegReader::Open(), leaving many threads running and never joined/closed. Also, adding some additional error message when attempting to callavcodec_open().