Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brightness, Hue, and Saturation effects #889

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Dec 22, 2022

Fix Brightness, Hue, and Saturation effects to fully support pre-multiplied colors (when alpha channel found)

Closes OpenShot/openshot-qt#4506

@jonoomph
Copy link
Member Author

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #889 (7e9cd26) into develop (4fbb439) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #889      +/-   ##
===========================================
- Coverage    51.95%   51.91%   -0.05%     
===========================================
  Files          188      188              
  Lines        16394    16409      +15     
===========================================
  Hits          8518     8518              
- Misses        7876     7891      +15     
Impacted Files Coverage Δ
src/effects/Brightness.cpp 1.38% <0.00%> (-0.18%) ⬇️
src/effects/Hue.cpp 1.44% <0.00%> (-0.12%) ⬇️
src/effects/Saturation.cpp 0.92% <0.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonoomph jonoomph merged commit 99aab0a into develop Dec 22, 2022
@jonoomph jonoomph deleted the fix-effects-premultiplied branch December 22, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Brightness & Contrast' and 'Hue' effects not doing very well
1 participant