Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Files should have NO image data (allowing lower layers to show through) #921

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

jonoomph
Copy link
Member

Small refactor to ensure that audio files have no image data - and allow videos below them to show through...

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #921 (89714b6) into develop (b21a686) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #921      +/-   ##
===========================================
- Coverage    54.21%   54.19%   -0.02%     
===========================================
  Files          190      190              
  Lines        16592    16599       +7     
===========================================
+ Hits          8995     8996       +1     
- Misses        7597     7603       +6     
Impacted Files Coverage Δ
src/Clip.h 68.75% <ø> (ø)
src/effects/Caption.cpp 0.00% <0.00%> (ø)
src/FrameMapper.cpp 92.13% <50.00%> (ø)
src/Clip.cpp 69.74% <83.33%> (-0.05%) ⬇️
src/Timeline.cpp 55.84% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonoomph jonoomph merged commit 5174608 into develop Apr 16, 2023
@jonoomph jonoomph deleted the audio-background-transparent branch April 16, 2023 16:46
@dahu1985
Copy link

dahu1985 commented Apr 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants