Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Validate and improve interpolation #16

Open
3 tasks
timmens opened this issue Jun 19, 2023 · 0 comments
Open
3 tasks

ENH: Validate and improve interpolation #16

timmens opened this issue Jun 19, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@timmens
Copy link
Member

timmens commented Jun 19, 2023

There are a few issues regarding interpolation on grids that need to be validated and/or improved:

  • Validate that the behavior of the interpolators when called on values outside the grid is well-documented, correct, and behaves according to the "law of least surprise".
    Note: Follow discussion in Update grids.py and interpolation.py #69.
  • Check whether RegularGridInterpolator could be an improvement over map_coordinates for the interpolation.
  • Add possibility for custom grids (besides linear and logarithmic)
    Potential use cases: Kinks in the tax schedule, etc.
    Implementation: Passing the custom grids to LCM's internals will be easy. The complexity of this feature stems from the fact that we need to write a get_custom_grid_coordinate function, that returns a generalized coordinate value for the interpolation.
@timmens timmens added the enhancement New feature or request label Jun 19, 2023
@timmens timmens self-assigned this Jun 19, 2023
@timmens timmens changed the title ENH: Check whether interpolation functions work outside defined domain ENH: Validate and improve interpolation May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant