Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the short proposal form for concept notes that are requesting less than 100k #717

Closed
danblah opened this issue Nov 15, 2018 · 16 comments · Fixed by #1412
Closed
Assignees
Labels
Status: Needs testing Tickets that need testing/qa

Comments

@danblah
Copy link
Contributor

danblah commented Nov 15, 2018

@frjo and @todd-dembrey, not sure how big/small this is. in the previous app, a concept note with the amount value of 100k or less was assigned a less onerous form to complete when invited to proposal. can we bring this back quickly?

@danblah danblah added this to the Current release milestone Nov 15, 2018
@frjo
Copy link
Contributor

frjo commented Nov 16, 2018

@danblah This is some work I believe. Setting up a separate fund/round/forms for this is of cource possible but I assube that is not an option.

You want to add three application forms to a fund. One concept note form . Two proposal forms, one small and one large. Then when an Concept note is invited for a proposal the system shoul look at the amount requested and for 100k or less pick the small form and for larger amounts pick the larger form.

In another issue you also mentioned wanting to allow the lead to pick between the different proposal forms manually when progressing an application, is that still so?

@tmsndrs
Copy link

tmsndrs commented Nov 19, 2018

Currently the field in the concept note that asks for the amount is also not specifically in $ so we would need to change that if we want to use that value here.

@frjo frjo removed their assignment Nov 29, 2018
@danblah
Copy link
Contributor Author

danblah commented Dec 18, 2018

Would this be easier if which proposal to create and go to next was a manual process? maybe something that a manager selects/checks at the invite to proposal status update?

How about this workflow...

  • Manager creates three application forms (concept note, standard proposal, small proposal)
  • Manager creates/edits fund page which now has a non-required field within the forms box for "Small amount form"
  • Manager selects the appropriate form if the fund requires.
  • When a submission is within a round that has a small amount form set, after the manager selects "Invite to proposal" and progress, add an option for the manager to select "Use small amount form".
  • Upon sending of determination, the small amount form is used to create the proposal the applicant is invited to complete.

@danblah
Copy link
Contributor Author

danblah commented Feb 20, 2019

@frjo, bumping this.

@danblah
Copy link
Contributor Author

danblah commented Apr 25, 2019

Adding this to the mini sprint @frjo and @fourthletter cause its needed. We should probably start a discussion here on how best to do this.

@todd-dembrey
Copy link
Contributor

@danblah I think your implementation in #717 (comment) is a reasonable approach.

There is an assumption that each phase has 1 form associated with it, I'll need to have a look at how much this would need to change. There is a helper method associated with the form selection for applications so shouldn't be too onerous.

I think we should address this process in two tickets:

  1. Ability to include multiple forms at the proposal stage (admin configuration) and a field for selecting the proposal form to use (whilst inviting to proposal).
  2. Ability to vary the Proposal form based on a specified criteria.
  • Criteria to be defined, but would use MustIncludeBlocks e.g. ValueBlock and a gt/lt selector for variing the value.
  • Adding additional criteria (e.g. geographic/category) could be interesting but might be better handled using the manual assignment process developed in 1.

@frjo frjo assigned todd-dembrey and unassigned Parbhat Apr 26, 2019
@frjo
Copy link
Contributor

frjo commented Apr 26, 2019

I was pondering a simpler solution with the field groups + trigger fields we added some time back. But for this separate forms is probably better.

@gibbsmaya gibbsmaya modified the milestones: 2019-Q2, Todd mini sprint Apr 26, 2019
@gibbsmaya
Copy link

Initial work for this is for Todd to outline implementation plan for this work in enough detail so that it can potentially be undertaken by someone other than him.

@todd-dembrey
Copy link
Contributor

As the application holds a reference to the form that the user is responding to we only need to make the choice of which forms to use once. So the bulk of this work will focus on storing the form-stage data and the ability to then vary that form on progression. I have outlined below the various changes that are needed as i see them.

Add in the concept of a stage to the application model.
This will involve adding in some concept of stage on the model definition.

  • The simplest approach would be adding a IntegerField which can be used to represent the Stage that the form is associated with. However this is not a nice user experience.
    • My preferred approach would be to convert the forms field to include a stage block which could give the following data structure:
- Application
    - Stage Block
         - Form Block
             - Form 1
    - Stage Block
         - Form Block
             - Form 2
             - Criteria
         - Form Block
             - Form 3
  • The criteria would be added at a later date and this first implementation would focus on the adding in the stage with multiple forms.

Add in the ability to vary the destination form from the determination page.

Pass the chosen form from the determination view into the stage progression.

@todd-dembrey todd-dembrey assigned frjo and unassigned todd-dembrey May 20, 2019
@danblah danblah removed this from the 2019-Q2 milestone Jul 1, 2019
@frjo
Copy link
Contributor

frjo commented Jul 29, 2019

@Parbhat I talks this over with @saoun, @fourthletter and @danblah in a meeting last week and this is what got decided:

  • Ability to add any number of proposal forms to a found/round.
  • On the determination when staff "invites to a proposal" add a field to select the proposals forms.
    1. The field should only show if there are more than one option.
    2. Please make the first proposal form the default.

@Parbhat
Copy link
Contributor

Parbhat commented Jul 30, 2019

Requirements look good. Thanks.

@frjo
Copy link
Contributor

frjo commented Aug 16, 2019

@danblah @saoun @fourthletter This is now ready to test on https://test-apply.opentech.fund. I believe @Parbhat have implemented it really nicely.

  1. Edit a Fund that has Concept/Proposal and add any number of 2 stage proposal forms.
  2. Create a new round for that Fund.
  3. Submit a Concept.
  4. Invite that Concept to a Proposal and you find a proposal form select field at the top of the determination form (if there are more than one proposal form).
  5. Pick the Proposal form you want for the submission in question.
  6. Confirm that the proposal have the correct form and that it can be edited/reviewed etc. as normal.

@fourthletter
Copy link
Contributor

Dearest @frjo I've added 2 stage proposal forms to 1) IFF [https://test-apply.opentech.fund/admin/pages/822/edit/?next=/admin/funds/round/] and 2) Rapid Response [https://test-apply.opentech.fund/admin/pages/823/edit/?next=/admin/funds/round/]

While these forms are almost perfect in every way, how do I add forms to the "No, I'm smaller than a bread box" option?

Example:
https://test-apply.opentech.fund/rapid-response-archive-fund/

image

@frjo
Copy link
Contributor

frjo commented Aug 21, 2019

@fourthletter That is not how it's supposed to work. I have set up an example according to my comment above on test now.

This is what I did:

  1. Added a second proposal form to the Internet Freedom Fund, see https://test-apply.opentech.fund/admin/pages/729/edit/. For this example I added the "Fellowship Proposal" application form, in reality you would most likely build a custom form to add.
  2. Create a new IFF round, see https://test-apply.opentech.fund/admin/pages/823/edit/
  3. Submit a concept note for the new round, see https://test-apply.opentech.fund/apply/submissions/76/

You can now go to https://test-apply.opentech.fund/apply/submissions/76/ and invite it to a proposal.

On the Determination form there are a new popup meny at the top where you can pick one of the proposal forms that was added to the Fund in step 1.

@fourthletter
Copy link
Contributor

fourthletter commented Aug 22, 2019

@frjo I tested this issue and results were successful. Thanks!

[] Staff sees new popup menu with two different proposals options on determination form
[] Staff sends out proposal option A to applicant A
[] Staff sends out proposal option B to applicant B
[] Both applicants received correct proposals.
[] Applicants were able to submit proposals to system

My usability concern is that it is not clear whether an individual received a particular application after the determination message has been sent. For example, I do not know if an applicant received the long proposal, short proposal, fellowship, etc. unless I have a clear grasp of the questions associated with the application

@frjo
Copy link
Contributor

frjo commented Aug 22, 2019

@fourthletter would it work to have this information show up on the determination? Or can you suggest another place?

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs testing Tickets that need testing/qa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants