Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarations folder on server leaves a dirt git after install #9

Open
martinratinaud opened this issue Jan 19, 2023 · 0 comments
Open

Comments

@martinratinaud
Copy link
Member

martinratinaud commented Jan 19, 2023

It's not really a problem and we can keep it like this but while investigating failing deployment of contrib, I found it weird that git status gave a not clean folder and I got a bit confused.

In fact, the deployment process

  • creates a pm2.config.cjs file
  • creates a .env file
  • replace the name of package-lock with the name of the folder

that are then not versioned files in git.

This could be fixed if need be by

  • adding a .gitignore (either in declarations repo or through ansible by appending those rules to existing ones)
  • changing the name inside package-lock.json of declarations repo with ${instance} instead of ${instance}-declarations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant