Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce non-URL-form DOIs to URL-form DOIs? #45

Open
jar398 opened this issue Jun 10, 2017 · 0 comments
Open

Coerce non-URL-form DOIs to URL-form DOIs? #45

jar398 opened this issue Jun 10, 2017 · 0 comments

Comments

@jar398
Copy link
Member

jar398 commented Jun 10, 2017

For historical reasons, phylesystem contains a mix of DOIs in URL form (http://dx.doi.org/10....) and non-URL form (10....). This issue OpenTreeOfLife/opentree#1069 proposes the obvious fix, which is to make a pass over phylesystem to normalize all the DOIs. That is a fine solution, and makes life easy for all clients of phylesystem. There is an alternative approach, which is to change all clients (including otindex) to permit either form of DOI, and then normalize on ingest (e.g. so that study duplication detection works). That is also a fine approach; it saves the pain of having to modify lots of phylesystem nexson files, and deals with unnormalized DOIs coming from other sources, such as old snapshots or commits of phylesystem, nexson files that might have been squirreled away somewhere, and so on.

I don't really want to prejudice the decision either way. If the decision is that the clients are to be modified, then otindex is one of the clients, so the issue is relevant to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant