You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For historical reasons, phylesystem contains a mix of DOIs in URL form (http://dx.doi.org/10....) and non-URL form (10....). This issue OpenTreeOfLife/opentree#1069 proposes the obvious fix, which is to make a pass over phylesystem to normalize all the DOIs. That is a fine solution, and makes life easy for all clients of phylesystem. There is an alternative approach, which is to change all clients (including otindex) to permit either form of DOI, and then normalize on ingest (e.g. so that study duplication detection works). That is also a fine approach; it saves the pain of having to modify lots of phylesystem nexson files, and deals with unnormalized DOIs coming from other sources, such as old snapshots or commits of phylesystem, nexson files that might have been squirreled away somewhere, and so on.
I don't really want to prejudice the decision either way. If the decision is that the clients are to be modified, then otindex is one of the clients, so the issue is relevant to this repository.
The text was updated successfully, but these errors were encountered:
For historical reasons, phylesystem contains a mix of DOIs in URL form (http://dx.doi.org/10....) and non-URL form (10....). This issue OpenTreeOfLife/opentree#1069 proposes the obvious fix, which is to make a pass over phylesystem to normalize all the DOIs. That is a fine solution, and makes life easy for all clients of phylesystem. There is an alternative approach, which is to change all clients (including otindex) to permit either form of DOI, and then normalize on ingest (e.g. so that study duplication detection works). That is also a fine approach; it saves the pain of having to modify lots of phylesystem nexson files, and deals with unnormalized DOIs coming from other sources, such as old snapshots or commits of phylesystem, nexson files that might have been squirreled away somewhere, and so on.
I don't really want to prejudice the decision either way. If the decision is that the clients are to be modified, then otindex is one of the clients, so the issue is relevant to this repository.
The text was updated successfully, but these errors were encountered: