Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tree and study properties hack #46

Open
snacktavish opened this issue Apr 10, 2019 · 3 comments
Open

Fix tree and study properties hack #46

snacktavish opened this issue Apr 10, 2019 · 3 comments
Assignees
@snacktavish

Comments

@snacktavish
Copy link
Member

This mixes together JSON and non JSON properties in a confusing way. https://github.com/OpenTreeOfLife/otindex/blob/options/otindex/util.py#L14

Potentially related to:
#31

#29
@snacktavish snacktavish self-assigned this Apr 10, 2019
@snacktavish snacktavish mentioned this issue May 1, 2019
Merged
@snacktavish
Copy link
Member Author

@kcranston Should we update the tree and studies properties that are returned and API docs to only include these properties? #16
Will updating the properties that are searchable require incrementing the api?

@snacktavish
Copy link
Member Author

snacktavish commented Jun 14, 2019 •
edited
Loading

#18 I was confused by the "tree properties not in nexsons" bit of this sissue. Original label is in nexsons, right?

@snacktavish
Copy link
Member Author

@kcranston This was fixed in 259f670, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snacktavish snacktavish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snacktavish