Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to off Test Signing in buildtap.py #169

Open
lucidmaj7 opened this issue May 10, 2024 · 1 comment
Open

How to off Test Signing in buildtap.py #169

lucidmaj7 opened this issue May 10, 2024 · 1 comment

Comments

@lucidmaj7
Copy link

lucidmaj7 commented May 10, 2024

Since File Digest Algorithm is not set in the test signing settings of the visual studio project, it is attempted with sha1. However, sha1 is not supported and sha256 is recommended. (sha1 is deprecated.)

When building with buildtap.py, it tries test signing by default, but the build fails for this reason.

  The driver will be test-signed. Driver signing options can be changed from the project properties.
  Sign Inputs: C:\Users\..............\tap0000.sys
  C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x86\signtool.exe sign /ph /sha1 "E81EDA6C7D8D72045CADBEA3FE0625EDEF77C047"
SIGNTASK : SignTool error : No file digest algorithm specified. Please specify the digest algorithm with the /fd flag. Using /fd SHA256 is recomme
nded and more secure than SHA1. Calling signtool with /fd sha1 is equivalent to the previous behavior. In order to select the hash algorithm used
in the signing certificate's signature, use the /fd certHash option. [C:\Users\.......\tap-windows6\src\tap-windows6.vcxproj]

I wish it was possible to build without testsign.

@lucidmaj7
Copy link
Author

lucidmaj7 commented May 10, 2024

Adding /p:SignMode=Off to msbuild.exe turns test signing off.

  def build_ewdk(self, project_file, arch):
        self.run_ewdk('msbuild.exe /p:SignMode=Off %s /p:Configuration=%s /p:Platform=%s' % (
               project_file,
               self.configuration,
               self.architecture_platform_map[arch]
               ))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant