Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong use of "subtrahend" and "minuend" in comments #442

Closed
ggballas opened this issue Sep 2, 2022 · 0 comments · Fixed by #449
Closed

Wrong use of "subtrahend" and "minuend" in comments #442

ggballas opened this issue Sep 2, 2022 · 0 comments · Fixed by #449
Assignees
@andrew-fleming

Comments

@ggballas
Copy link

ggballas commented Sep 2, 2022

Minor issue but may lead to confusion and wrong usage. The term "minuend" is wrongly used for the "subtrahend" and vice-versa.

📝 Details

In src/openzeppelin/security/safemath/library.cairo lines 32 and 50, "minuend" and "subtrahend" are mixed up.
@andrew-fleming andrew-fleming mentioned this issue Sep 9, 2022
Merged
@martriay martriay moved this to 📋 Backlog in Cairo team Sep 10, 2022
@martriay martriay added this to the current milestone Sep 10, 2022
@martriay martriay moved this from 📋 Backlog to 👀 In review in Cairo team Sep 10, 2022
Repository owner moved this from 👀 In review to ✅ Resolved in Cairo team Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-fleming andrew-fleming

Labels
None yet
Projects
No open projects
Cairo team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump to cairo v0.10 andrew-fleming/cairo-contracts
3 participants
@ggballas @martriay @andrew-fleming