Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add preset contracts #683

Closed
martriay opened this issue Jul 30, 2023 · 6 comments
Closed

Re-add preset contracts #683

martriay opened this issue Jul 30, 2023 · 6 comments

Comments

@martriay
Copy link
Contributor

For ERC20 and ERC721 tokens mainly

@martriay martriay added this to the after milestone Jul 30, 2023
@martriay martriay moved this to 📋 Backlog in Contracts for Cairo Jul 30, 2023
@martriay martriay modified the milestones: after, next Aug 22, 2023
@bal7hazar
Copy link
Contributor

bal7hazar commented Aug 23, 2023

Hey, I just finished a first Cairo 2 version of our ERC-3525 including presets (using unsafe_new_contract_state exclusively).
Feel free to benchmark it if needed for your contracts, I would be glad to help.

@martriay
Copy link
Contributor Author

martriay commented Aug 23, 2023

@bal7hazar thanks. I'm not sure I understand correctly, are you suggesting we include ERC-3525 into our library or are you suggesting comparing ERC-20 and ERC-721 performance against it?

@bal7hazar
Copy link
Contributor

@bal7hazar thanks. I'm not sure I understand correctly, are you suggesting we include ERC-3525 into our library or are you suggesting comparing ERC-20 and ERC-721 performance against it?

@martriay hey, it was just to show how I wrote presets for ERC3525 in case you would like to benchmark them before you write ERC20 and ERC721 presets

@martriay
Copy link
Contributor Author

@bal7hazar what you mean by benchmarking? performance or to simply compare?

@bal7hazar
Copy link
Contributor

@martriay more about the architecture and the design of the solution

@martriay martriay modified the milestones: next, after Sep 27, 2023
@martriay martriay modified the milestones: after, later Oct 17, 2023
@ericnordelo ericnordelo mentioned this issue Oct 30, 2023
3 tasks
@martriay
Copy link
Contributor Author

Closing this issue as we decided to follow the steps of the Contracts for Solidity repo and leave only basic presets in the repo, and let Wizard for (coming soon for cairo 1+) to cover the rest.

@ggonzalez94 ggonzalez94 removed this from the 1. current milestone Sep 2, 2024
@ggonzalez94 ggonzalez94 moved this from 📋 Backlog to ✅ Resolved in Contracts for Cairo Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Resolved
Development

No branches or pull requests

3 participants