Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink main docsite navbar #749

Closed
martriay opened this issue Sep 23, 2023 · 2 comments · Fixed by #838
Closed

Rethink main docsite navbar #749

martriay opened this issue Sep 23, 2023 · 2 comments · Fixed by #838

Comments

@martriay
Copy link
Contributor

Re evaluate overall navbar order and grouping.

For example, we could distinguish between general concepts in the lib (quickstart, interfaces, extensibility, etc) and contract modules (account, tokens, upgrades, etc).
@martriay martriay added this to the after milestone Sep 23, 2023
@martriay martriay changed the title Rethink main navbar Rethink main docsite navbar Sep 23, 2023
@martriay martriay moved this to 📋 Backlog in Contracts for Cairo Sep 29, 2023
@martriay martriay modified the milestones: after, later Oct 17, 2023
@martriay martriay modified the milestones: later, after Nov 24, 2023
@martriay
Copy link
Contributor Author

martriay commented Dec 2, 2023

Example of how it could look like
image

@martriay martriay mentioned this issue Dec 2, 2023
Merged
@ericnordelo
Copy link
Member

Looking better already! A couple of comments:

  • I think the Wizard should be right after Overview because it is a powerful tool and people can easily miss it this way.
  • I would remove the See Also section if it contains only the Contracts for Solidity entry.
  • If we have Learn and Modules, we should avoid collapsing all the sections by default IMO, and leave at least these two open by default (UI)

@martriay martriay modified the milestones: after, next Dec 10, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Resolved in Contracts for Cairo Dec 13, 2023
@ericnordelo ericnordelo removed this from the 1. current milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Contracts for Cairo
Status: ✅ Resolved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs navbar OpenZeppelin/cairo-contracts
2 participants
@martriay @ericnordelo