Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting updates on the doc of AccessControl._grantRole and AccessControl._revokeRole #3376

Closed
DocCon-team opened this issue Apr 29, 2022 · 0 comments · Fixed by #3421
Closed

Comments

@DocCon-team
Copy link

DocCon-team commented Apr 29, 2022

Hi,

The AccessControl._grantRole function might emit a RoleGranted event, which is not documented in its doc.

emit RoleGranted(role, account, _msgSender());

Similarly, the AccessControl._revokeRole function might emit a RoleRevoked event, which is not documented in its doc either.

emit RoleRevoked(role, account, _msgSender());

A potential fix could be adding "Might emit a {RoleGranted} event" to the doc of AccessControl._grantRole, and adding a "Might emit {RoleRevoked} event" to the doc of AccessControl._revokeRole, respectively.

Could you please check it?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant