Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VestingWallet's beneficiary zero address check to Ownable #4511

Closed
ernestognw opened this issue Aug 4, 2023 · 0 comments · Fixed by #4531
Closed

Move VestingWallet's beneficiary zero address check to Ownable #4511

ernestognw opened this issue Aug 4, 2023 · 0 comments · Fixed by #4531

Comments

@ernestognw
Copy link
Member

ernestognw commented Aug 4, 2023 •
edited
Loading

Description

Currently, VestingWallet makes a check to validate that the owner is not the zero address. However, we consider this check should be performed in the Ownable contract instead.

maybe not in the PR, but we should remove that check here and move it to Ownable's constructor

Originally posted by @Amxx in #4508 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move beneficiary zero address check to Ownable NishantKoyalwar/openzeppelin-contracts
1 participant
@ernestognw