Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ERC20FailedDecreaseAllowance error #4598

Closed
trevorgjohnson opened this issue Sep 13, 2023 · 2 comments · Fixed by #4604
Closed

Remove deprecated ERC20FailedDecreaseAllowance error #4598

trevorgjohnson opened this issue Sep 13, 2023 · 2 comments · Fixed by #4604

Comments

@trevorgjohnson
Copy link
Contributor

With the inclusion of #4585, increaseAllowance and decreaseAllowance was removed.

This just leaves 1 custom error that is related that now removed functionality.

image
@frangio
Copy link
Contributor

frangio commented Sep 13, 2023

Thanks this is correct. Do you want to submit a PR?

@trevorgjohnson trevorgjohnson mentioned this issue Sep 14, 2023
Merged
3 tasks
@trevorgjohnson
Copy link
Contributor Author

Thanks this is correct. Do you want to submit a PR?

Yep! This issue should be resolved with #4604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated 'ERC20FailedDecreaseAllowance' error trevorgjohnson/openzeppelin-contracts
2 participants
@frangio @trevorgjohnson