Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _moveDelegateVotes internal in Votes.sol #5006

Closed
ernestognw opened this issue Apr 8, 2024 · 1 comment
Closed

Make _moveDelegateVotes internal in Votes.sol #5006

ernestognw opened this issue Apr 8, 2024 · 1 comment

Comments

@ernestognw
Copy link
Member

ernestognw commented Apr 8, 2024

🧐 Motivation

A question came in the forum regarding customizing the quorum of a Governor so that it takes the amount of delegated votes into account. This use case is already possible by tracking the total of delegate votes through both the _transferVotingUnits and _delegate functions but it's unnecessarily expensive and it splits the logic in two when it can already be tracked by overriding _moveDelegateVotes.

Reference

📝 Details

Making _moveDelegatesVotes internal enables overriding.

@ernestognw
Copy link
Member Author

Closing in favor of #4989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant