Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Improve integration tests setup #1284

Open
frangio opened this issue Nov 14, 2019 · 0 comments
Open

Improve integration tests setup #1284

frangio opened this issue Nov 14, 2019 · 0 comments
Labels
priority:low Low priority topic:tech-debt Pending technical debt

Comments

@frangio
Copy link
Contributor

frangio commented Nov 14, 2019

Our integration tests are not satisfactory in catching several types of errors because they are not set up isolated, but sharing dependencies with the rest of the monorepo.

I think the correct way to set them up would be to use npm pack and store the .tgz as a build artifact, then pick it up from a different job and install it, which mirrors a real scenario much better. A bit of a challenge is to make it also work locally, although in that case it doesn't need to be as robust, as long as the CI catches errors later.

Because this is a monorepo with multiple packages, it might not be enough to use the .tgz since they depend on one another. What the web3.js project is doing is quite cool: they set up a private npm registry in the CI where they put all the package candidates, and the tests install from there. (web3/web3.js#3157)

@frangio frangio added the kind:tests Writing or improving tests of the SDK itself label Nov 14, 2019
@spalladino spalladino added topic:tech-debt Pending technical debt and removed kind:tests Writing or improving tests of the SDK itself labels Dec 11, 2019
@frangio frangio added the priority:low Low priority label Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority:low Low priority topic:tech-debt Pending technical debt
Projects
None yet
Development

No branches or pull requests

2 participants