From bb306f352cf6f5d1846e5cc2a761a82b15a6b637 Mon Sep 17 00:00:00 2001 From: smb2268 Date: Mon, 21 Oct 2024 16:00:14 -0400 Subject: [PATCH] move navigate out of props --- .../RunHeaderBannerContainer/index.tsx | 11 +++++++---- .../Devices/ProtocolRun/ProtocolRunHeader/index.tsx | 3 --- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderBannerContainer/index.tsx b/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderBannerContainer/index.tsx index db4073a77b7..5c7c6e01621 100644 --- a/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderBannerContainer/index.tsx +++ b/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderBannerContainer/index.tsx @@ -1,4 +1,5 @@ import { useTranslation } from 'react-i18next' +import { useNavigate } from 'react-router-dom' import { Box, @@ -34,24 +35,24 @@ export type RunHeaderBannerContainerProps = ProtocolRunHeaderProps & { runErrors: UseRunErrorsResult runHeaderModalContainerUtils: UseRunHeaderModalContainerResult hasDownloadableFiles: boolean - deviceDetailsLink: () => void } // Holds all the various banners that render in ProtocolRunHeader. export function RunHeaderBannerContainer( props: RunHeaderBannerContainerProps ): JSX.Element | null { + const navigate = useNavigate() const { runStatus, enteredER, runHeaderModalContainerUtils, hasDownloadableFiles, - deviceDetailsLink, + robotName, } = props const { analysisErrorModalUtils } = runHeaderModalContainerUtils const { t } = useTranslation(['run_details', 'shared']) - const isDoorOpen = useIsDoorOpen(props.robotName) + const isDoorOpen = useIsDoorOpen(robotName) const { showRunCanceledBanner, @@ -114,7 +115,9 @@ export function RunHeaderBannerContainer( { + navigate(`/devices/${robotName}`) + }} > {t('device_details')} diff --git a/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/index.tsx b/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/index.tsx index 78cc2ea2da0..c6d33879be9 100644 --- a/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/index.tsx +++ b/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/index.tsx @@ -108,9 +108,6 @@ export function ProtocolRunHeader( 'outputFileIds' in runRecord.data && runRecord.data.outputFileIds.length > 0 } - deviceDetailsLink={() => { - navigate(`/devices/${robotName}`) - }} {...props} />