Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, robot_server): allow non-standard tip racks in tip length calibration from dashboard #13891

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented Nov 1, 2023

Overview

Mirror our approach for loading an alternate tip rack into a legacy calibration session from deck/pipette-offset to tip length calibration

Closes RAUT-809

Review requests

  • starting with no tip length calibration values on an OT-2 proceed to the calibration dashboard
  • you should be able to select an alternate tip rack for performing TLC on a pipette.
  • that alternate tip rack should be used when calibrating the pipette offset in the next step

Risk assessment

high, this touches both FE and BE and the code is quite old and brittle

…libration from dashboard

Mirror our approach for loading an alternate tip rack into a legacy calibration session from
deck/pipette-offset to tip length calibration

Closes RAUT-809
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #13891 (a391041) into edge (b242919) will increase coverage by 0.00%.
Report is 7 commits behind head on edge.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13891   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files        2501     2501           
  Lines       70338    70360   +22     
  Branches     8600     8610   +10     
=======================================
+ Hits        49844    49862   +18     
- Misses      18398    18400    +2     
- Partials     2096     2098    +2     
Flag Coverage Δ
app 68.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/CalibrateDeck/index.tsx 77.14% <ø> (ø)
app/src/organisms/CalibrateTipLength/index.tsx 75.00% <100.00%> (+0.71%) ⬆️
...organisms/CalibrationPanels/Introduction/index.tsx 85.29% <100.00%> (+0.44%) ⬆️
...Dashboard/hooks/useDashboardCalibrateTipLength.tsx 78.94% <ø> (ø)
...t_server/robot/calibration/tip_length/user_flow.py 94.73% <ø> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

@b-cooper b-cooper marked this pull request as ready for review November 2, 2023 18:28
@b-cooper b-cooper requested review from a team as code owners November 2, 2023 18:28
@b-cooper b-cooper requested review from koji, shlokamin, sfoster1 and mjhuff and removed request for a team and koji November 2, 2023 18:28
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected and code makes sense. Thanks for walking me through the backend!

@b-cooper b-cooper merged commit 3058653 into edge Nov 8, 2023
24 checks passed
@b-cooper b-cooper deleted the app_allow-non-default-tip-rack-tlc branch November 8, 2023 20:58
ncdiehl11 pushed a commit that referenced this pull request Nov 14, 2023
…libration from dashboard (#13891)

Mirror our approach for loading an alternate tip rack into a legacy calibration session from
deck/pipette-offset to tip length calibration

Closes RAUT-809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants