Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix calibration copy, 96 wizard attach title #13927

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Nov 6, 2023

fix RQA-1866, RQA-1767

Overview

Fix two 96-channel bugs:

  1. Title of 96-channel attach wizard changes to "Detach and attach 96-channel" after attachment
  2. Robot settings calibration item mount listed as "left" instead of "both"

Test Plan

  1. Attach a 96-channel pipette with an empty gantry, see that for the duration of the wizard flow the title remains "Attach 96-Channel Pipette"
  2. Once the pipette is attached and calibrated, go to robot settings/calibration on desktop and see that under "Mount" you now see "Both"

Changelog

Memoize "isGantryEmpty" variable so it doesn't become false after 96-pipette is attached and update mount to say "both" when 96 channel is attached

Review requests

Look over code and test plan

Risk assessment

Low

@smb2268 smb2268 self-assigned this Nov 6, 2023
@smb2268 smb2268 requested a review from a team as a code owner November 6, 2023 20:16
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #13927 (c423d70) into edge (c4b3b56) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13927      +/-   ##
==========================================
- Coverage   70.82%   70.73%   -0.10%     
==========================================
  Files        2504     1629     -875     
  Lines       70465    54080   -16385     
  Branches     8616     3802    -4814     
==========================================
- Hits        49908    38252   -11656     
+ Misses      18457    15162    -3295     
+ Partials     2100      666    -1434     
Flag Coverage Δ
app 42.97% <ø> (-25.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 876 files with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@smb2268 smb2268 merged commit 3c4964e into edge Nov 6, 2023
22 checks passed
@smb2268 smb2268 deleted the app_96-cal-bugs branch November 6, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants