Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): update video assets for attach and detach 96-channel pipette #13929

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix(app): update video assets for attach and detach 96-channel pipette #13929

merged 1 commit into from
Nov 8, 2023

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Nov 6, 2023 •
edited by jira bot
Loading

closes RQA-1863

Overview

Update video assets for attach/detach 96-channel pipette due to stroke issue in existing animations

Test Plan

  • launch attach/detach flows for 96-channel pipette on desktop app and observe corrected animations

Changelog

  • replace video assets with corrected animations

Risk assessment

low

@ncdiehl11
fix(app): update video assets for attach and detach 96-channel pipette
af4eb8d 
Update video assets for attach/detach 96-channel pipette due to stroke issue in existing animations
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 6, 2023 21:09
@ncdiehl11 ncdiehl11 requested review from brenthagen and removed request for a team November 6, 2023 21:09
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #13929 (af4eb8d) into edge (3c4964e) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13929      +/-   ##
==========================================
+ Coverage   70.73%   70.82%   +0.09%     
==========================================
  Files        1629     2504     +875     
  Lines       54080    70468   +16388     
  Branches     3802     8617    +4815     
==========================================
+ Hits        38254    49910   +11656     
- Misses      15161    18457    +3296     
- Partials      665     2101    +1436
Flag Coverage Δ
app 68.79% <ø> (+25.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 875 files with indirect coverage changes

mjhuff
mjhuff approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ncdiehl11 ncdiehl11 merged commit b34462c into edge Nov 8, 2023
26 checks passed
ncdiehl11 added a commit that referenced this pull request Nov 14, 2023
@ncdiehl11
fix(app): update video assets for attach and detach 96-channel pipette (
8c55cb1 
#13929)

closes RQA-1863

Update video assets for attach/detach 96-channel pipette due to stroke issue in existing animations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@brenthagen brenthagen Awaiting requested review from brenthagen brenthagen is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @mjhuff