fix(app): module calibration should only use calibrated pipette #13956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13956 +/- ##
==========================================
- Coverage 70.71% 70.71% -0.01%
==========================================
Files 2504 2504
Lines 70674 70676 +2
Branches 8666 8667 +1
==========================================
Hits 49976 49976
- Misses 18590 18592 +2
Partials 2108 2108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
reviewed
Nov 8, 2023
Comment on lines
+200
to
+204
| if ( | ||
| currentStep == null || | ||
| attachedPipette?.data.calibratedOffset?.last_modified == null | ||
| ) | ||
| return null |
There was a problem hiding this comment.
I think the changes make sense, but these lines could be higher like right after currentStep(L76) 🤔
There was a problem hiding this comment.
I can't really move it much higher because you can't have an early return statement before all of the hooks are called and there are quite a few in the first two hundred lines
There was a problem hiding this comment.
oh, that totally makes sense. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We should not allow users to calibrate modules unless an attached pipette is calibrated. We should ensure a pipette has calibration data before selecting that as the pipette to use for module calibration.
Test Plan
Changelog
Review requests
Run through the test plan
Risk assessment
Low