-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): module calibration should only use calibrated pipette #13956
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13956 +/- ##
==========================================
- Coverage 70.71% 70.71% -0.01%
==========================================
Files 2504 2504
Lines 70674 70676 +2
Branches 8666 8667 +1
==========================================
Hits 49976 49976
- Misses 18590 18592 +2
Partials 2108 2108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
if ( | ||
currentStep == null || | ||
attachedPipette?.data.calibratedOffset?.last_modified == null | ||
) | ||
return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes make sense, but these lines could be higher like right after currentStep
(L76) 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really move it much higher because you can't have an early return statement before all of the hooks are called and there are quite a few in the first two hundred lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, that totally makes sense. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
We should not allow users to calibrate modules unless an attached pipette is calibrated. We should ensure a pipette has calibration data before selecting that as the pipette to use for module calibration.
Test Plan
Changelog
Review requests
Run through the test plan
Risk assessment
Low