Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): add deck config query refetch interval #14122

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

brenthagen
Copy link
Contributor

Overview

refetches the deck config on a 5 second interval on the device details page and in hooks that determine location conflicts

closes RQA-1993

Test Plan

Changelog

  • Adds deck config query polling

Review requests

confirm that the deck config updates within 5 seconds when updated by another client

Risk assessment

low

refetches the deck config on a 5 second interval on the device details page and in hooks that
determine location conflicts

closes RQA-1993
@brenthagen brenthagen requested a review from a team as a code owner December 6, 2023 21:35
@brenthagen brenthagen requested review from ncdiehl11 and a team and removed request for a team and ncdiehl11 December 6, 2023 21:35
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #14122 (90d1641) into chore_release-7.1.0 (463af32) will increase coverage by 0.00%.
Report is 1 commits behind head on chore_release-7.1.0.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14122   +/-   ##
====================================================
  Coverage                70.46%   70.47%           
====================================================
  Files                     2512     2512           
  Lines                    71200    71252   +52     
  Branches                  8964     8991   +27     
====================================================
+ Hits                     50174    50217   +43     
- Misses                   18835    18842    +7     
- Partials                  2191     2193    +2     
Flag Coverage Δ
app 67.70% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...evices/hooks/useModuleRenderInfoForProtocolById.ts 88.46% <100.00%> (+0.46%) ⬆️
...rc/organisms/ProtocolSetupModulesAndDeck/index.tsx 69.51% <100.00%> (+0.37%) ⬆️
app/src/resources/deck_configuration/hooks.ts 92.30% <100.00%> (+0.64%) ⬆️
...organisms/DeviceDetailsDeckConfiguration/index.tsx 63.63% <50.00%> (-1.99%) ⬇️
app/src/pages/Protocols/hooks/index.ts 71.64% <50.00%> (+0.42%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I think we need to update app/src/pages/DeckConfiguration/index.tsx too.

@brenthagen
Copy link
Contributor Author

lgtm

I think we need to update app/src/pages/DeckConfiguration/index.tsx too.

that page is different because we are initializing based on the query then modifying the deck. i think we may want staleTime: Infinity there, but should be ticketed separately.

@brenthagen brenthagen merged commit 9c008f2 into chore_release-7.1.0 Dec 7, 2023
28 checks passed
@brenthagen brenthagen deleted the app_deck-config-polling branch December 7, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants